Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix #61 - To, ToName and Substitution values getting jumbled. #65

Merged
merged 1 commit into from
May 23, 2015

Conversation

gs-spadmanabhan
Copy link
Contributor

Fix for To, ToName getting Jumbled.
Also found another bug in handling SendGrid Response. The error message sometimes appears in response Json as a "error" or "errors" key even thought the response has HTTP 200 ok status.. Added code change to handle this situation.

…led.

Also found another bug in handling SendGrid Response. Provided fix for that as well.
@eddiezane
Copy link
Contributor

Thanks for the PR!

@johnclaus - any chance I can get you to help test this please?

@gs-spadmanabhan
Copy link
Contributor Author

Is there anything, I can help?

@gs-spadmanabhan
Copy link
Contributor Author

Guys, any updates on this pull request? @eddiezane

@eddiezane
Copy link
Contributor

Will attend to this tomorrow @gs-spadmanabhan. Sorry for the delay!

@gs-spadmanabhan
Copy link
Contributor Author

I have written code for sub user management as well. Would you like me to send you a pull request? Also any updates on this PR?

@eddiezane eddiezane merged commit b0a4f03 into sendgrid:master May 23, 2015
@eddiezane
Copy link
Contributor

Thanks for contributing to SendGrid Open Source! We think it's awesome when community members contribute to our projects and want to celebrate that.

The following link will ask you to authenticate with Github (so we can verify your identity). You'll then be asked for your shipping address so that we can send you a thanks for contributing.

Click Here to Continue »

Once again, thank you!

@eddiezane
Copy link
Contributor

Sorry for the delay on this. I've uploaded the new version 2.2.2 to maven central.

Thanks for the offer on the subuser management. This library is going to only support sending mail until v3 of our API is released in the next few months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants