Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix java package names #306

Merged
merged 3 commits into from
Oct 23, 2018
Merged

Fix java package names #306

merged 3 commits into from
Oct 23, 2018

Conversation

btrajkovski
Copy link
Contributor

Java packages were not corresponding to the actual location of classes,
all packages were update to match class location.

@btrajkovski
Fix java package names
ac1a990 
Java packages were not corresponding to the actual location of classes,
all packages were update to match class location.
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 23, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 23, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 27, 2017
@thinkingserious
Copy link
Contributor

@btrajkovski

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@af4ro af4ro added status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Aug 21, 2018
@thinkingserious thinkingserious added the type: community enhancement feature request not on Twilio's roadmap label Oct 23, 2018
@thinkingserious thinkingserious merged commit 9bc569c into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @btrajkovski,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@childish-sambino childish-sambino mentioned this pull request Oct 19, 2020
Closed
6 tasks
akunzai added a commit to akunzai/log4j2-sendgrid-appender that referenced this pull request Nov 7, 2020
@akunzai
Update sendgrid-java dependency minimum version to 4.4.0
5011202 
- some class not found since sendgrid-java version 4.4.0
- see sendgrid/sendgrid-java#306
@akunzai akunzai mentioned this pull request Nov 7, 2020
Merged
@vanta
Copy link

vanta commented Mar 15, 2021

This change should be marked as MAJOR change as it is breaking the API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@btrajkovski @SendGridDX @thinkingserious @vanta @mbernier @af4ro @apigirl