Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "similar-code" issue in examples/categories/categories.java #329

Closed
thinkingserious opened this issue Oct 27, 2017 · 0 comments · Fixed by #360
Closed

Fix "similar-code" issue in examples/categories/categories.java #329

thinkingserious opened this issue Oct 27, 2017 · 0 comments · Fixed by #360
Labels
difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 27, 2017 •
edited by mbernier
Loading

Similar blocks of code found in 2 locations. Consider refactoring.

Take each of the examples and make them their own file.
Then create a README file that links to each example.

https://codeclimate.com/github/sendgrid/sendgrid-java/examples/categories/categories.java#issue_59f382fdba92590001000134
@mbernier mbernier added difficulty: easy fix is easy in difficulty good first issue labels Oct 27, 2017
derjayjay added a commit to derjayjay/sendgrid-java that referenced this issue Oct 28, 2017
@derjayjay
Fix for issue sendgrid#329
96a1317 
Split examples in multiple files
@derjayjay derjayjay mentioned this issue Oct 28, 2017
Merged
@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: twilio enhancement feature request on Twilio's roadmap and removed good first issue labels Feb 28, 2018
@childish-sambino childish-sambino removed the status: work in progress Twilio or the community is in the process of implementing label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: reorganize examples derjayjay/sendgrid-java
3 participants
@thinkingserious @mbernier @childish-sambino