Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude examples from go tests, Travis Job #273

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

anchepiece
Copy link
Contributor

Fixes #244

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Hello 👋,
Thanks sendgrid team for releasing and continually improving this library.

This is a minor fix that excludes code that shouldn't be tested in the examples, vendor, and docker directories.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 2, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #273 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #273   +/-   ##
=======================================
  Coverage   70.95%   70.95%           
=======================================
  Files           3        3           
  Lines         451      451           
=======================================
  Hits          320      320           
  Misses        127      127           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30c7277...16543b5. Read the comment docs.

@thinkingserious thinkingserious added type: bug bug in the library hacktoberfest difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Oct 3, 2018
@thinkingserious
Copy link
Contributor

Hello @anchepiece,

Thanks again for the PR!

It's HACKTOBERFEST! We want to show our appreciation by sending you some special Hacktoberfest swag. If you have not already, could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@thinkingserious thinkingserious merged commit 2b846cb into sendgrid:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: bug bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Coverage check should ignore examples?
3 participants