Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude time.Until lint error until we stop supporting Go 1.7 and lower #250

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

dmowcomber
Copy link
Contributor

@dmowcomber dmowcomber commented Jan 25, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

exclude time.Until lint error until we stop supporting Go 1.7 and lower

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 25, 2018
@codecov
Copy link

codecov bot commented Jan 25, 2018

Codecov Report

Merging #250 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   71.07%   71.07%           
=======================================
  Files           3        3           
  Lines         446      446           
=======================================
  Hits          317      317           
  Misses        125      125           
  Partials        4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5729161...02e699d. Read the comment docs.

@thinkingserious thinkingserious merged commit 0337b42 into master Jan 25, 2018
@thinkingserious
Copy link
Contributor

Hello @dmowcomber,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@dmowcomber dmowcomber deleted the exclue-lint-error branch January 25, 2018 18:19
@thinkingserious thinkingserious mentioned this pull request Jan 26, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants