Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for license date range #225

Merged
merged 1 commit into from
Oct 28, 2017
Merged

Add test for license date range #225

merged 1 commit into from
Oct 28, 2017

Conversation

m4ns0ur
Copy link
Contributor

@m4ns0ur m4ns0ur commented Oct 28, 2017

The test case should check the license
date range, if end date is this year.

Fixes #221

@m4ns0ur
Add test for license date range
fa13859 
The test case should check the license
date range, if end date is this year.

Fixes sendgrid#221

Signed-off-by: Mansour Rahimi <[email protected]>
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 28, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 28, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mbernier
Copy link
Contributor

Awesome!!

@mbernier mbernier added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 28, 2017
@mbernier mbernier merged commit 87a19c8 into sendgrid:master Oct 28, 2017
@thinkingserious
Copy link
Contributor

Hello @m4ns0ur,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@m4ns0ur m4ns0ur deleted the test-license-year branch October 29, 2017 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m4ns0ur @SendGridDX @mbernier @thinkingserious