Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megacheck found 2 small issues #215

Merged
merged 2 commits into from
Oct 29, 2017
Merged

Megacheck found 2 small issues #215

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80893f1
remove unused variable 'testAPIKey'
vaskoz Oct 27, 2017
e70577b
simplify boolean condition check
vaskoz Oct 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions sendgrid_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,13 @@ import (
)

var (
testAPIKey = "SENDGRID_APIKEY"
testHost = ""
prismPath = "prism"
prismArgs = []string{"run", "-s", "https://raw.githubusercontent.com/sendgrid/sendgrid-oai/master/oai_stoplight.json"}
prismCmd *exec.Cmd
buffer bytes.Buffer
curl *exec.Cmd
sh *exec.Cmd
testHost = ""
prismPath = "prism"
prismArgs = []string{"run", "-s", "https://raw.githubusercontent.com/sendgrid/sendgrid-oai/master/oai_stoplight.json"}
prismCmd *exec.Cmd
buffer bytes.Buffer
curl *exec.Cmd
sh *exec.Cmd
)

func TestMain(m *testing.M) {
Expand Down Expand Up @@ -162,7 +161,7 @@ func TestCustomHTTPClient(t *testing.T) {
if err == nil {
t.Error("A timeout did not trigger as expected")
}
if strings.Contains(err.Error(), "Client.Timeout exceeded while awaiting headers") == false {
if !strings.Contains(err.Error(), "Client.Timeout exceeded while awaiting headers") {
t.Error("We did not receive the Timeout error")
}
}
Expand Down