-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helping get golint to 100%. #200
Conversation
While I don't mean to be nitpicky, I just think It would be a nice-to-have if all of these methods were renamed and followed the Pascal case. The first letter of each word in the method name can be uppercased and the 'a' article dropped. For eg:- DeleteCampaign looks so much better than Deleteacampaign. Thoughts? @mbernier @thinkingserious @Cleanse |
@thinkingserious @Cleanse only worry there is already a PR #148 which has a lot of overlap wrt. |
Once I can merge #148 I will give this one a look! |
@tariq1890 could you please open a new issue regarding your point here:
I think this is a great point and want to have a separate conversation thread just for this. Thanks! |
@Cleanse ... thoughts on merging these conflicts? I would love to give credit where it's due - there's just quite a few merge conflicts here. Thoughts? |
Let me know what you would like me to fix, it seems like you're unsure. It's your project, I just wanted to help a bit during Hacktober. |
@Cleanse I believe that I resolved the conflicts. Can you please give this a double check and then we will get it merged. Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
Ahh yeah. It's working! |
❤️ |
If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries. Our agenda would be: Explore what you liked and is there anything we can do to improve? You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain. Thank you so much, Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager |
This will have to hold off, I am currently out of state dealing with health issues, my free time is super limited. Apologies. |
No worries, we wish the you the best @Cleanse! |
Fixed //comments.