Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helping get golint to 100%. #200

Merged
merged 15 commits into from
Oct 30, 2017
Merged

Helping get golint to 100%. #200

merged 15 commits into from
Oct 30, 2017

Conversation

Cleanse
Copy link
Contributor

@Cleanse Cleanse commented Oct 23, 2017

Fixed //comments.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 23, 2017
@SendGridDX
Copy link

SendGridDX commented Oct 23, 2017

CLA assistant check
All committers have signed the CLA.

@tariq1890
Copy link
Contributor

tariq1890 commented Oct 23, 2017

While I don't mean to be nitpicky, I just think It would be a nice-to-have if all of these methods were renamed and followed the Pascal case. The first letter of each word in the method name can be uppercased and the 'a' article dropped.

For eg:- DeleteCampaign looks so much better than Deleteacampaign. Thoughts? @mbernier @thinkingserious @Cleanse

@srini156
Copy link
Contributor

@thinkingserious @Cleanse only worry there is already a PR #148 which has a lot of overlap wrt. golint fixes.

@mbernier
Copy link
Contributor

Once I can merge #148 I will give this one a look!

@mbernier
Copy link
Contributor

@tariq1890 could you please open a new issue regarding your point here:

I just think It would be a nice-to-have if all of these methods were renamed and followed the Pascal case. The first letter of each word in the method name can be uppercased and the 'a' article dropped.

For eg:- DeleteCampaign looks so much better than Deleteacampaign.

I think this is a great point and want to have a separate conversation thread just for this. Thanks!

@mbernier
Copy link
Contributor

@Cleanse ... thoughts on merging these conflicts? I would love to give credit where it's due - there's just quite a few merge conflicts here. Thoughts?

@tariq1890
Copy link
Contributor

@mbernier I have created #204

@Cleanse
Copy link
Contributor Author

Cleanse commented Oct 25, 2017

Let me know what you would like me to fix, it seems like you're unsure. It's your project, I just wanted to help a bit during Hacktober.

@mbernier
Copy link
Contributor

@Cleanse I believe that I resolved the conflicts. Can you please give this a double check and then we will get it merged.

Thank you!!

Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@mbernier mbernier added difficulty: hard fix is hard in difficulty hacktoberfest labels Oct 28, 2017
@mbernier
Copy link
Contributor

Ahh yeah. It's working!

@mbernier mbernier merged commit e606aad into sendgrid:master Oct 30, 2017
@thinkingserious
Copy link
Contributor

Hello @Cleanse,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Cleanse
Copy link
Contributor Author

Cleanse commented Oct 30, 2017

❤️

@mbernier
Copy link
Contributor

@Cleanse

If you are interested, we would love the opportunity to talk to you about Hacktoberfest and our API libraries.

Our agenda would be: Explore what you liked and is there anything we can do to improve?

You can grab a time on my calendar that works for you and we can have a chat on Google Hangout or Skype. If you prefer, you can email me using my GitHub username at my company’s domain.

Thank you so much,

Matt Bernier - @mbernier - SendGrid Developer Experience Product Manager
Elmer Thomas - @thinkingserious - SendGrid Developer Experience Engineer
@sendgrid

@Cleanse
Copy link
Contributor Author

Cleanse commented Nov 26, 2017

This will have to hold off, I am currently out of state dealing with health issues, my free time is super limited. Apologies.

@thinkingserious
Copy link
Contributor

No worries, we wish the you the best @Cleanse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: hard fix is hard in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants