Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Getenv("message") parameter more professional #197

Merged
merged 7 commits into from
Oct 23, 2018
Merged

Make Getenv("message") parameter more professional #197

merged 7 commits into from
Oct 23, 2018

Conversation

nafisfaysal
Copy link

close #195

@thinkingserious thinkingserious added status: code review request requesting a community code review or review from Twilio difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 22, 2017
@thinkingserious
Copy link
Contributor

@nafisfaysal

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@dmowcomber
Copy link
Contributor

LGTM

@dmowcomber dmowcomber mentioned this pull request Feb 9, 2018
Closed
4 tasks
@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Mar 6, 2018
@thinkingserious thinkingserious merged commit 7dcfc0a into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @nafisfaysal,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Getenv("message") parameter more professional
3 participants
@nafisfaysal @thinkingserious @dmowcomber