Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows users to submit rfc822 formatted email addresses #194

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Allows users to submit rfc822 formatted email addresses #194

merged 2 commits into from
Oct 23, 2018

Conversation

tariq1890
Copy link
Contributor

No description provided.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 22, 2017
@tariq1890 tariq1890 mentioned this pull request Oct 22, 2017
Closed
@tariq1890
Copy link
Contributor Author

tariq1890 commented Oct 22, 2017 •
edited
Loading

Leaving this here for reference

@tariq1890
Copy link
Contributor Author

@mbernier Can you review this PR? Let me know if there are any issues with these changes.

@thinkingserious thinkingserious added hacktoberfest difficulty: hard fix is hard in difficulty labels Oct 28, 2017
dmowcomber
dmowcomber reviewed Feb 6, 2018
View reviewed changes
helpers/mail/mail_v3.go Outdated
@@ -569,3 +570,11 @@ func NewSandboxModeSetting(enable bool, forwardSpam bool, spamCheck *SpamCheckSe
SpamCheck: spamCheck,
}
}

func ParseEmail(emailInfo string) (*Email, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a doc comment above here explaining what ParseEmail does?

@tariq1890
Copy link
Contributor Author

@dmowcomber Done

@codecov
Copy link

codecov bot commented Feb 6, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@b64df65). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #194   +/-   ##
=========================================
  Coverage          ?   71.39%           
=========================================
  Files             ?        3           
  Lines             ?      451           
  Branches          ?        0           
=========================================
  Hits              ?      322           
  Misses            ?      125           
  Partials          ?        4
Impacted Files Coverage Δ
helpers/mail/mail_v3.go 98.12% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b64df65...e34dbb7. Read the comment docs.

@dmowcomber
Copy link
Contributor

LGTM

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review request requesting a community code review or review from Twilio labels Mar 6, 2018
@tariq1890
Copy link
Contributor Author

Will this ever be merged?LOL

@thinkingserious
Copy link
Contributor

Yes. However, we have a major update being worked on by @suchitparikh at the moment.

@thinkingserious thinkingserious merged commit 7440206 into sendgrid:master Oct 23, 2018
@thinkingserious
Copy link
Contributor

Hello @tariq1890,

Thanks again for the PR!

We appreciate your contribution and look forward to continued collaboration. Thanks!

Team SendGrid DX

@tariq1890 tariq1890 deleted the rfc822-email branch October 24, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmowcomber dmowcomber dmowcomber left review comments

Assignees
No one assigned
Labels
difficulty: hard fix is hard in difficulty status: ready for deploy code ready to be released in next deploy type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tariq1890 @dmowcomber @thinkingserious