Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Correcting *.md files using Grammarly #97

Merged
merged 2 commits into from
Aug 14, 2020
Merged

docs: Correcting *.md files using Grammarly #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e18419
Correcting *.md files using Grammarly
pushkyn Oct 5, 2018
31dc433
Merge branch 'main' into fix-issue-96
Aug 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,14 @@ This project adheres to [Semantic Versioning](http://semver.org/).
### BREAKING Change
- [Pull #14](https://github.com/sendgrid/java-http-client/pull/14): Make response have private variables
- Fixed [Issue #12](https://github.com/sendgrid/java-http-client/issues/12): The public Response variables should be private
- The breaking change is that variables that were public are now private and accessable only via getters and setters
- The breaking change is that variables that were public are now private and accessible only via getters and setters
- BIG thanks to [Diego Camargo](https://github.com/belfazt) for the pull request!

## [3.0.0] - 2016-10-06
### BREAKING Change
- [Pull #15](https://github.com/sendgrid/java-http-client/pull/15): Update the request object with sensible defaults and access methods
- Fixes [Issue #13](https://github.com/sendgrid/java-http-client/issues/13): Update the Request object with sensible defaults and access methods
- The breaking change is that variables that were public are now private and accessable only via getters and setters
- The breaking change is that variables that were public are now private and accessible only via getters and setters
- BIG thanks to [Diego Camargo](https://github.com/belfazt) for the pull request!

## [2.3.4] - 2016-08-09
Expand Down
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Hello! Thank you for choosing to help contribute to one of the SendGrid open source projects. There are many ways you can contribute and help is always welcome. We simply ask that you follow the following contribution policies.
Hello! Thank you for choosing to help contribute to one of the SendGrid open source projects. There are many ways you can contribute and help is always welcome. We simply ask that you follow the following contribution policies.

- [Feature Request](#feature-request)
- [Submit a Bug Report](#submit-a-bug-report)
Expand All @@ -9,7 +9,7 @@ Hello! Thank you for choosing to help contribute to one of the SendGrid open sou
- [Creating a Pull Request](#creating-a-pull-request)
- [Code Reviews](#code-reviews)

We use [Milestones](https://github.com/sendgrid/java-http-client/milestones) to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions and additional PRs are welcomed and encouraged.
We use [Milestones](https://github.com/sendgrid/java-http-client/milestones) to help define current roadmaps, please feel free to grab an issue from the current milestone. Please indicate that you have begun work on it to avoid collisions. Once a PR is made, community review, comments, suggestions, and additional PRs are welcomed and encouraged.

<a name="feature-request"></a>
## Feature Request
Expand All @@ -31,7 +31,7 @@ A software bug is a demonstrable issue in the code base. In order for us to diag
Before you decide to create a new issue, please try the following:

1. Check the Github issues tab if the identified issue has already been reported, if so, please add a +1 to the existing post.
2. Update to the latest version of this code and check if issue has already been fixed
2. Update to the latest version of this code and check if the issue has already been fixed
3. Copy and fill in the Bug Report Template we have provided below

### Please use our Bug Report Template
Expand Down Expand Up @@ -157,7 +157,7 @@ Please run your code through:

4. Commit your changes in logical chunks. Please adhere to these [git commit
message guidelines](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html)
or your code is unlikely be merged into the main project. Use Git's
or your code is unlikely to be merged into the main project. Use Git's
[interactive rebase](https://help.github.com/articles/interactive-rebase)
feature to tidy up your commits before making them public.

Expand Down