Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC 1.1.9 #107

Merged
merged 2 commits into from
Dec 11, 2024
Merged

RC 1.1.9 #107

merged 2 commits into from
Dec 11, 2024

Conversation

semuadmin
Copy link
Contributor

@semuadmin semuadmin commented Dec 11, 2024

pygnssutils Pull Request Template

Description

  1. Fix for IndexError: list index out of range error in format_conn on platforms with no IP6 support.
  2. ubx CLI utilities moved to pyubxutils - ubxsave, ubxload, ubxcompare, ubxsetrate, ubxsimulator. For the time being, pyubxutils will remain a dependency of pygnssutils and will be installed alongside it via pip, and from pygnssutils import UBXSimulator will still work as an import statement, but these will be removed altogether in v1.2.0.

Fixes: IndexError: list index out of range error in format_conn on platforms with no IP6 support.

Testing

Please test all changes, however trivial, against the supplied pytest suite tests/test_*.py. Please describe any test cases you have amended or added to this suite to maintain >= 99% code coverage.

Checklist:

  • I agree to abide by the code of conduct (see CODE_OF_CONDUCT.md).
  • My code follows the style guidelines of this project (see CONTRIBUTING.md).
  • I have performed a self-review of my own code.
  • (if appropriate) I have cited my u-blox documentation source(s).
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • (if appropriate) I have added test cases to the tests/test_*.py unittest suite to maintain >= 99% code coverage.
  • I have tested my code against the full tests/test_*.py unittest suite.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed my commits.
  • I understand and acknowledge that the code will be published under a BSD 3-Clause license.

@semuadmin semuadmin added the enhancement New feature or request label Dec 11, 2024
@semuadmin semuadmin added this to the RC 1.1.9 milestone Dec 11, 2024
@semuadmin semuadmin requested a review from a team December 11, 2024 07:45
@semuadmin semuadmin self-assigned this Dec 11, 2024
@semuadmin semuadmin marked this pull request as draft December 11, 2024 07:45
@semuadmin semuadmin added the bug Something isn't working label Dec 11, 2024
@semuadmin semuadmin marked this pull request as ready for review December 11, 2024 16:41
@semuadmin semuadmin merged commit ea3e205 into main Dec 11, 2024
@semuadmin semuadmin deleted the RC-1.1.9 branch December 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants