feat: new policy view with login CTA #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kopecs
commented
Dec 2, 2024
|
screenshots? |
ajbt200128
reviewed
Dec 2, 2024
|
I'm going to move this back to draft while I update the login flow stuff we discussed since it is causing some cases where the UI would be stale here for now. |
kopecs
force-pushed
the
cooper/code-7796
branch
from
0d43e80 to
9ba8dec
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 6, 2025
ajbt200128
approved these changes
Feb 6, 2025
Merge activity
|
This will show a prompt to login or add a local configuration if none is present. If a configuration is present and/or the user is logged in, it will show the applied configuration.
kopecs
force-pushed
the
cooper/code-7796
branch
from
9ba8dec to
50ded7c
Compare
kopecs
force-pushed
the
graphite-base/186
branch
from
1f7b582 to
984146f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The policy view is blank on logging in. This still version of this commit needs some imports updated. Planning on going through and reorganizing imports generally / improving autoformatting and then rebasing probably.
PR checklist:
If you're unsure about any of this, please see: