Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(move-on-aptos): bug fixes and upstream updates #486

Merged
merged 9 commits into from
Jun 26, 2024

Conversation

ArArgon
Copy link
Contributor

@ArArgon ArArgon commented Jun 18, 2024

Changes

  • Fix parsing rules for typed metavariables;
    • Typed metavariables and type hinting have the same grammar: '(', $._expr, ')' vs '(', $.identifier, ':', $.type, ')', the workaround is implemented in the CST to AST converter.
  • Fix type argument ambiguities
  • Reformat testcases in semgrep.txt
  • Support matching let expression
  • Update upstream tree-sitter parser

Please remember to execute lang/release move-on-aptos to sync the semgrep-move-on-aptos repo.

Security

  • Change has no security implications (otherwise, ping the security team)

@ArArgon ArArgon changed the title fix(move-on-aptos): correctly parse typed metavariables and update parser fix(move-on-aptos): bug fixes and upstream updates Jun 21, 2024
@ArArgon ArArgon marked this pull request as ready for review June 26, 2024 16:55
@ArArgon ArArgon requested a review from a team as a code owner June 26, 2024 16:55
@ArArgon ArArgon requested review from mjambon, brandonspark and aryx and removed request for a team June 26, 2024 16:55
Copy link
Contributor

@brandonspark brandonspark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done! you've done this in a very canonical way

@ArArgon
Copy link
Contributor Author

ArArgon commented Jun 26, 2024

well done! you've done this in a very canonical way

Could you help merging it?

@brandonspark brandonspark merged commit ca1e791 into semgrep:main Jun 26, 2024
2 checks passed
@aryx
Copy link
Collaborator

aryx commented Jun 27, 2024

I've run the release script and updated the semgrep-move-on-aptos repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants