This repository has been archived by the owner on Jun 22, 2024. It is now read-only.
forked from SeleniumHQ/docker-selenium
-
Notifications
You must be signed in to change notification settings - Fork 26
32 bit arm build #3
Merged
jamesmortensen
merged 7 commits into
seleniumhq-community:32-bit-arm
from
Coliinnn:32-bit-arm
Jan 19, 2022
Merged
32 bit arm build #3
jamesmortensen
merged 7 commits into
seleniumhq-community:32-bit-arm
from
Coliinnn:32-bit-arm
Jan 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires 'linux/arm/v7' in build.sh Requires 'armhf' in Base/Dockerfile
I wasn't sure where 'TARGETARCH' gets it values, so in my local instance I removed the variable and hard-coded the correct value to make it build successfully.
Only version 97 supports 32-bit ARM
With what you have here, along with a few changes I made to derive the ARCH environment variable from You can pull them from here and try them out on x86_64, arm64, and armhf platforms:
There's a few things that I had to change. In the Base/Dockerfile, to build multi-arch, we can check TARGETARCH and TARGETVARIANT and set ARCH based on them:
Here's a diff of the changes that I'll apply before merging into the trunk:
|
Changes merged and updates pushed here: https://github.com/seleniarm/docker-selenium/tree/32-bit-arm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to support the build for 32-bit ARM support. See the discussion in SeleniumHQ#1076. Please note that my additions may need edits to make sure that they have no unintended consequences for the project.
Motivation and Context
To run on Raspberry Pi (4), with the 32-bit Raspbian OS.
Types of changes
Checklist