Skip to content
This repository was archived by the owner on Jun 22, 2024. It is now read-only.

Removing obsolete and not supported shell scripts. Updating docs with… #24

Merged
merged 5 commits into from
Oct 18, 2022

Conversation

jamesmortensen
Copy link

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This provides some updates to the documentation and removes outdated and no longer supported shell scripts. This fixes #23

Motivation and Context

This helps users and contributors more easily build the ARM images on their own.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

… the supported method for building the ARM images locally.
…arch to reflect the nature of building for multiple architectures, not just arm64. Updated Makefile with new Dockerfile,multi-arch name. Removed obsolete generation and build scripts, outdated experimental Ubuntu Dockerfile, and updated documentation to move how to start containers towards the top.
@jamesmortensen jamesmortensen merged commit 303edea into trunk Oct 18, 2022
@jamesmortensen jamesmortensen deleted the fix-build-instructions branch October 18, 2022 04:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 Feature]: Update documentation on how to build seleniarm images manually. README is out of date.
1 participant