This repository was archived by the owner on Jun 22, 2024. It is now read-only.
Using docker manifest to tag the multi arch images with browser, driver, and selenium versions #11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to tag the images after they've been pushed is a bit tricky when they're multi-arch images. This is because docker engine can only load images for one platform at a time, while the builder can only push multi-arch images without loading them in the context.
In order to maintain the same image hashes (and make it easy to verify images with different tags are the same), we use docker manifest to create a new manifest with a specific tag and then amend it with the images from the different architectures using the --amend flag. Afterwards, we push the manifest to Docker Hub. We use the same process to push the latest tag as well.
Types of changes
Checklist