fix tags filter to retrieve specified tags not excluding specified ta…

…gs (#34) * fix tags filter to retrieve specified tags not excluding specified tags * fix tests and return value when filters is empty
sekipaolo · Oct 10, 2017 · d517b3e · d517b3e
1 parent d7cf6da
commit d517b3e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pypingdom/client.py b/pypingdom/client.py
@@ -43,8 +43,8 @@ def get_check(self, name=None, _id=None):
 
     def get_checks(self, filters=None):
         if filters is None:
-            filters = {}
-        return [c for c in self.checks.values() if len(set(filters.get("tags", [])).intersection(set([x['name']
+            return [c for c in self.checks.values()]
+        return [c for c in self.checks.values() if not len(set(filters.get("tags", [])).intersection(set([x['name']
                 for x in c.tags]))) == 0]
 
     def create_check(self, name, obj):

diff --git a/pypingdom/tests/test_client.py b/pypingdom/tests/test_client.py
@@ -70,4 +70,4 @@ def test_get_checks(self, m):
         self.assertTrue(all(isinstance(x, Check) for x in res))
 
         res = client.get_checks(filters={"tags": ['apache']})
-        self.assertEqual(len(res), 2)
+        self.assertEqual(len(res), 1)