test: Package-scoped event_loop fixture no longer leaks into other te…

…sts.

The expected behaviour is that the `event_loop` fixture defined in `tests/sessionloop/conftest.py` is torn down when all tests in `tests/sessionloop` are complete. Running the tests with the pytest option --setup-show pointed out that the fixture is torn down at the end of the test session, instead. This is an unintended side effect of the sessionloop test which may affect other tests in the test suite.

Reducing the fixture scope from "package" to "module" results in the expected behaviour. The module was renamed to reflect the fact that the tests do not use a session scope.

Signed-off-by: Michael Seifert <[email protected]>

tests/sessionloop/conftest.py → tests/loop_fixture_scope/conftest.py

@@ -3,14 +3,14 @@
 import pytest
 
 
-class CustomSelectorLoopSession(asyncio.SelectorEventLoop):
+class CustomSelectorLoop(asyncio.SelectorEventLoop):
     """A subclass with no overrides, just to test for presence."""
 
 
-loop = CustomSelectorLoopSession()
+loop = CustomSelectorLoop()
 
 
-@pytest.fixture(scope="package")
+@pytest.fixture(scope="module")
 def event_loop():
     """Create an instance of the default event loop for each test case."""
     yield loop

tests/sessionloop/test_session_loops.py → tests/loop_fixture_scope/test_loop_fixture_scope.py

@@ -1,4 +1,4 @@
-"""Unit tests for overriding the event loop with a session scoped one."""
+"""Unit tests for overriding the event loop with a larger scoped one."""
 import asyncio
 
 import pytest
@@ -8,7 +8,7 @@
 async def test_for_custom_loop():
     """This test should be executed using the custom loop."""
     await asyncio.sleep(0.01)
-    assert type(asyncio.get_event_loop()).__name__ == "CustomSelectorLoopSession"
+    assert type(asyncio.get_event_loop()).__name__ == "CustomSelectorLoop"
 
 
 @pytest.mark.asyncio