Fix allowed_msg uncapped spend limit bug #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzang2019
approved these changes
Jun 13, 2023
philipsu522
requested changes
Jun 13, 2023
There was a problem hiding this comment.
Why is this different than OSS?
https://github.com/cosmos/cosmos-sdk/blob/main/x/feegrant/filtered_fee.go#L70-L87
OSS version has the same feegrant allowed_msg implementation as the one we have, so it's likely that the OSS version also has this bug |
philipsu522
approved these changes
Jun 13, 2023
added 2 commits
June 13, 2023 12:04
|
Apply the OSS fix: cosmos/cosmos-sdk#16097 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #284 +/- ##
==========================================
+ Coverage 54.93% 54.98% +0.04%
==========================================
Files 619 619
Lines 51509 51524 +15
==========================================
+ Hits 28297 28329 +32
+ Misses 21185 21162 -23
- Partials 2027 2033 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
A grantee can use uncapped grant from a grantee when a grant is using AllowedMsgAllowance type, even with the SpendLimit specified. This issue is resulted from the types.Any Allowance object inside the AllowedMsgAllowance is not updated correctly.
This PR fixes this issue and adds according unit tests to the AllowedMsgAllowance.
Testing performed to validate your change