Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tracer/simulation RPC #2071

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

improve tracer/simulation RPC #2071

wants to merge 2 commits into from

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Feb 11, 2025

Describe your changes and provide context

Use the same logic as actual execution to perform tracer/simulation requests, so that the result has higher fidelity.

Testing performed to validate your change

todo

@codchen codchen force-pushed the tony/redo-simulation branch 2 times, most recently from 8240527 to 08e03fa Compare February 20, 2025 04:33
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 69.11765% with 21 lines in your changes missing coverage. Please review.

Project coverage is 61.58%. Comparing base (f875297) to head (b6c2114).

Files with missing lines Patch % Lines
evmrpc/simulate.go 58.13% 11 Missing and 7 partials ⚠️
app/app.go 33.33% 2 Missing ⚠️
x/evm/keeper/msg_server.go 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
+ Coverage   61.51%   61.58%   +0.07%     
==========================================
  Files         265      265              
  Lines       24710    24690      -20     
==========================================
+ Hits        15200    15206       +6     
+ Misses       8382     8356      -26     
  Partials     1128     1128              
Files with missing lines Coverage Δ
evmrpc/send.go 29.47% <100.00%> (ø)
evmrpc/server.go 87.13% <100.00%> (ø)
evmrpc/tracers.go 59.22% <100.00%> (ø)
x/evm/keeper/msg_server.go 71.84% <90.90%> (+0.30%) ⬆️
app/app.go 65.38% <33.33%> (+0.05%) ⬆️
evmrpc/simulate.go 70.43% <58.13%> (+5.22%) ⬆️

... and 1 file with indirect coverage changes

@codchen codchen force-pushed the tony/redo-simulation branch from 08e03fa to b6c2114 Compare February 20, 2025 06:10
@codchen codchen enabled auto-merge (squash) February 20, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants