Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move token id from Data to Topic in ERC721 Event #1837

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Conversation

jewei1997
Copy link
Contributor

@jewei1997 jewei1997 commented Aug 28, 2024

Describe your changes and provide context

Token id should be the 3rd/last topic, not be in the Data field for ERC721 events.

Testing performed to validate your change

existing tests.

@jewei1997 jewei1997 changed the title Fix ERC721 Topics Add Token Id as Topic in ERC721 Events Aug 28, 2024
@jewei1997 jewei1997 changed the title Add Token Id as Topic in ERC721 Events Move token id from Data to Topic in ERC721 Event Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 60.92%. Comparing base (0ebeaeb) to head (b1d92ab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/receipt.go 50.00% 8 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1837      +/-   ##
==========================================
- Coverage   60.94%   60.92%   -0.03%     
==========================================
  Files         257      257              
  Lines       22686    22690       +4     
==========================================
- Hits        13827    13824       -3     
- Misses       7877     7884       +7     
  Partials      982      982              
Files with missing lines Coverage Δ
app/receipt.go 78.54% <50.00%> (+0.33%) ⬆️

... and 3 files with indirect coverage changes

@jewei1997 jewei1997 merged commit 18c3e2d into main Aug 29, 2024
50 of 51 checks passed
@jewei1997 jewei1997 deleted the fix-erc721-topics branch August 29, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants