Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork event manager when creating EVM snapshots #1831

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Aug 23, 2024

Describe your changes and provide context

Create a new event manager when snapshots are created so that events created in the new snapshot can be cleanly reverted when the snapshot itself is reverted.

Not apphash-breaking because events are not part of consensus

Testing performed to validate your change

unit test

@codchen codchen force-pushed the fork-event-manager branch from cf42630 to ac739ff Compare August 23, 2024 03:30
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.98%. Comparing base (e8e4b3b) to head (ac739ff).
Report is 145 commits behind head on main.

Files Patch % Lines
x/evm/state/statedb.go 85.71% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1831      +/-   ##
==========================================
- Coverage   61.64%   60.98%   -0.67%     
==========================================
  Files         365      257     -108     
  Lines       26178    22565    -3613     
==========================================
- Hits        16138    13761    -2377     
+ Misses       8967     7831    -1136     
+ Partials     1073      973     -100     
Files Coverage Δ
x/evm/state/state.go 95.45% <100.00%> (ø)
x/evm/state/statedb.go 50.43% <85.71%> (-1.53%) ⬇️

... and 176 files with indirect coverage changes

@codchen codchen merged commit dd7c43d into main Aug 23, 2024
49 checks passed
@codchen codchen deleted the fork-event-manager branch August 23, 2024 10:10
yzang2019 added a commit that referenced this pull request Aug 27, 2024
* main:
  Increase timeout for evm hardhat tests (#1827)
  Fork event manager when creating EVM snapshots (#1831)
  Gas mispricing in cw vm patch (#1824)
  Remove dex actually (#1816)
  Bump seidb to fix receipt missing on restart issue (#1817)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants