Do not charge gas for feecollector address query #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
changed the title
codchen
force-pushed
the
fix-feecollector-cache
branch
from
9966e05 to
7bbb5c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
==========================================
- Coverage 60.83% 60.73% -0.10%
==========================================
Files 257 257
Lines 22490 22491 +1
==========================================
- Hits 13682 13661 -21
- Misses 7842 7866 +24
+ Partials 966 964 -2
|
philipsu522
approved these changes
Jul 30, 2024
philipsu522
pushed a commit
that referenced
this pull request
Jul 30, 2024
Do not charge cache for feecollector address query
yzang2019
added a commit
that referenced
this pull request
Aug 15, 2024
* main: Add more DEX dapp tests (#1809) Add basic LST integration tests (#1814) Allow CW->ERC pointers to be called through wasmd precompile (#1785) Bump nonce even if tx fails (#1778) Fix docker setup for local cluster (#1806) Tune Configs (#1813) V5.7.5 release (#1805) Evidence Max Bytes Update (#1812) Add dApp Tests (#1802) [EVM] Tune configs (#1800) Revert dex removal (#1801) Do not charge gas for feecollector address query (#1795)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Charging gas for a potentially cached operation could cause non-determinism
Testing performed to validate your change
applied on archive node to get it out of apphash error