Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Random to Hash of Block Timestamp #1740

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Update Random to Hash of Block Timestamp #1740

merged 3 commits into from
Jun 21, 2024

Conversation

Kbhat1
Copy link
Contributor

@Kbhat1 Kbhat1 commented Jun 20, 2024

Describe your changes and provide context

  • Replace Random field with hash of block timestamp

Testing performed to validate your change

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.58%. Comparing base (3b8b27c) to head (296fad4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   60.64%   60.58%   -0.07%     
==========================================
  Files         372      372              
  Lines       27022    27022              
==========================================
- Hits        16388    16370      -18     
- Misses       9536     9552      +16     
- Partials     1098     1100       +2     
Files Coverage Δ
x/evm/keeper/keeper.go 49.46% <100.00%> (ø)

... and 3 files with indirect coverage changes

x/evm/keeper/keeper.go Outdated Show resolved Hide resolved
Copy link
Contributor

@jewei1997 jewei1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion but overall LGTM, would also be good to add this to our docs for where we diverge from a regular EVM impl.

@Kbhat1 Kbhat1 merged commit c5610ba into main Jun 21, 2024
49 checks passed
@Kbhat1 Kbhat1 deleted the UpdateRandom branch June 21, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants