Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle VM error code properly #1726

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Conversation

codchen
Copy link
Collaborator

@codchen codchen commented Jun 10, 2024

Describe your changes and provide context

Within EVM module we still want to treat the newly added VM error code as "successful" on the tx-level, in the sense that we don't want to perform a tx-level rollback.

Testing performed to validate your change

unit tests

@udpatil udpatil changed the base branch from main to BumpSeiCosmos June 10, 2024 21:15
@udpatil udpatil force-pushed the handle-evm-vm-errorcode branch from 8498afd to 50b6261 Compare June 10, 2024 21:20
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.83%. Comparing base (79318fb) to head (50b6261).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           BumpSeiCosmos    #1726      +/-   ##
=================================================
+ Coverage          60.81%   60.83%   +0.02%     
=================================================
  Files                370      370              
  Lines              27436    27436              
=================================================
+ Hits               16685    16692       +7     
+ Misses              9609     9602       -7     
  Partials            1142     1142              
Files Coverage Δ
x/evm/keeper/keeper.go 49.46% <100.00%> (ø)

... and 2 files with indirect coverage changes

@udpatil udpatil merged commit 3f31815 into BumpSeiCosmos Jun 10, 2024
29 checks passed
@udpatil udpatil deleted the handle-evm-vm-errorcode branch June 10, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants