Bring CW721 pointer contract up to spec #1668
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i-chain into improved-cw721-pointer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
==========================================
+ Coverage 60.70% 60.72% +0.02%
==========================================
Files 367 367
Lines 26784 26809 +25
==========================================
+ Hits 16258 16280 +22
+ Misses 9429 9420 -9
- Partials 1097 1109 +12
|
stevenlanders
approved these changes
May 15, 2024
besated
approved these changes
May 15, 2024
philipsu522
pushed a commit
that referenced
this pull request
May 16, 2024
* POC - bring CW721 pointer contract up to spec * fixes to cw721 bindings * uses cw2981 ExecuteMsg/QueryMsg and implements extensions * attempt fix royalty info response * Update dummy ERC721.sol * Update EVM bindings for 721 queries * Fix bigInt handling * Fix up typing * Tidy up cwerc721 queries * Add more tests * Bug fixes * Update cwerc721.wasm builds * Fix contract syntax * Fix query_test for EVM query handlers * minor fixes * Update cwerc721 build * Add more cwerc721 pointer tests * Implement check_royalties * syncs up events with whats emitted by current cw nfts * adds evm_address extension query * no op query_all_operators * Update build * Update pointer contract api/bin/wasm files * Fix typo in contract test ABI * rebase --------- Co-authored-by: davyli <[email protected]> Co-authored-by: shab <[email protected]>
|
Closing. #1673 is a copy and was merged in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change
x/evm/client/wasm/query_test.goto test out two new EVM queries ("TotalSupply" and "RoyaltyInfo")contracts/test/CW721toERC721PointerTest.jsthat tests out new query responses