Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify antehandler to improve logic #1163

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Modify antehandler to improve logic #1163

merged 2 commits into from
Dec 5, 2023

Conversation

udpatil
Copy link
Collaborator

@udpatil udpatil commented Dec 4, 2023

Describe your changes and provide context

Testing performed to validate your change

Integration testing tests the affected cases, but doesnt apply towards coverage

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #1163 (be0b0b0) into main (c071491) will decrease coverage by 0.31%.
Report is 49 commits behind head on main.
The diff coverage is 60.61%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1163      +/-   ##
==========================================
- Coverage   63.93%   63.63%   -0.31%     
==========================================
  Files         254      256       +2     
  Lines       16234    16633     +399     
==========================================
+ Hits        10380    10584     +204     
- Misses       5349     5547     +198     
+ Partials      505      502       -3     
Files Coverage Δ
aclmapping/dex/mappings.go 100.00% <100.00%> (ø)
aclmapping/oracle/mappings.go 100.00% <100.00%> (ø)
aclmapping/tokenfactory/mappings.go 100.00% <100.00%> (ø)
app/antedecorators/gasless.go 88.72% <100.00%> (ø)
app/test_helpers.go 48.53% <ø> (ø)
app/upgrades.go 40.74% <100.00%> (+20.74%) ⬆️
oracle/price-feeder/config/config.go 74.07% <ø> (+4.41%) ⬆️
oracle/price-feeder/oracle/filter.go 91.42% <100.00%> (+0.90%) ⬆️
oracle/price-feeder/oracle/provider/crypto.go 73.12% <100.00%> (ø)
oracle/price-feeder/oracle/util.go 97.50% <100.00%> (+5.39%) ⬆️
... and 52 more

... and 2 files with indirect coverage changes

@udpatil udpatil merged commit f322f84 into main Dec 5, 2023
37 of 38 checks passed
@udpatil udpatil deleted the test-acl-register branch December 5, 2023 19:10
yzang2019 pushed a commit that referenced this pull request Feb 5, 2024
update wasm register to traverse nested authz exec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants