more test

sei-protocol · Nov 14, 2024 · 596b6b9 · 596b6b9
1 parent cf0b261
commit 596b6b9
Show file tree

Hide file tree

Showing 2 changed files with 56 additions and 2 deletions.
diff --git a/app/receipt.go b/app/receipt.go
@@ -186,6 +186,11 @@ func (app *App) translateCW721Event(ctx sdk.Context, wasmEvent abci.Event, point
 			return nil, false
 		}
 		sender := app.GetEvmAddressAttribute(ctx, wasmEvent, "sender")
+		// unfortunately CW721 transfer events differ from ERC721 transfer events
+		// in that CW721 include sender (which can be different than owner) whereas
+		// ERC721 always include owner. The following logic refer to the owner
+		// event emitted before the transfer and use that instead to populate the
+		// synthetic ERC721 event.
 		ownerEvents := GetEventsOfType(response, wasmtypes.EventTypeCW721PreTransferOwner)
 		for _, ownerEvent := range ownerEvents {
 			if len(ownerEvent.Attributes) != 3 {

diff --git a/app/receipt_test.go b/app/receipt_test.go
@@ -321,10 +321,10 @@ func TestEvmEventsForCw721(t *testing.T) {
 	require.True(t, found)
 	require.Equal(t, common.HexToHash("0x1").Bytes(), receipt.Logs[0].Data)
 
-	// burn on behalf
-	payload = []byte("{\"burn\":{\"token_id\":\"2\"}}")
+	// transfer on behalf
 	k.BankKeeper().MintCoins(ctx, "evm", amt)
 	k.BankKeeper().SendCoinsFromModuleToAccount(ctx, "evm", recipient, amt)
+	payload = []byte(fmt.Sprintf("{\"transfer_nft\":{\"token_id\":\"2\",\"recipient\":\"%s\"}}", recipient.String()))
 	msg = &wasmtypes.MsgExecuteContract{
 		Sender:   recipient.String(),
 		Contract: contractAddr.String(),
@@ -354,6 +354,55 @@ func TestEvmEventsForCw721(t *testing.T) {
 	require.Equal(t, "0x0000000000000000000000000000000000000000000000000000000000000002", tokenIdHash)
 	require.Equal(t, common.HexToHash("0x0").Bytes(), receipt.Logs[0].Data)
 
+	// transfer back
+	payload = []byte(fmt.Sprintf("{\"transfer_nft\":{\"token_id\":\"2\",\"recipient\":\"%s\"}}", creator.String()))
+	msg = &wasmtypes.MsgExecuteContract{
+		Sender:   recipient.String(),
+		Contract: contractAddr.String(),
+		Msg:      payload,
+	}
+	txBuilder = testkeeper.EVMTestApp.GetTxConfig().NewTxBuilder()
+	txBuilder.SetMsgs(msg)
+	txBuilder.SetFeeAmount(sdk.NewCoins(sdk.NewCoin("usei", sdk.NewInt(1000000))))
+	txBuilder.SetGasLimit(300000)
+	tx = signTx(txBuilder, privKeyRecipient, k.AccountKeeper().GetAccount(ctx, recipient))
+	txbz, err = testkeeper.EVMTestApp.GetTxConfig().TxEncoder()(tx)
+	require.Nil(t, err)
+	sum = sha256.Sum256(txbz)
+	res = testkeeper.EVMTestApp.DeliverTx(ctx.WithEventManager(sdk.NewEventManager()), abci.RequestDeliverTx{Tx: txbz}, tx, sum)
+	require.Equal(t, uint32(0), res.Code)
+
+	// burn on behalf
+	payload = []byte("{\"burn\":{\"token_id\":\"2\"}}")
+	msg = &wasmtypes.MsgExecuteContract{
+		Sender:   recipient.String(),
+		Contract: contractAddr.String(),
+		Msg:      payload,
+	}
+	txBuilder = testkeeper.EVMTestApp.GetTxConfig().NewTxBuilder()
+	txBuilder.SetMsgs(msg)
+	txBuilder.SetFeeAmount(sdk.NewCoins(sdk.NewCoin("usei", sdk.NewInt(1000000))))
+	txBuilder.SetGasLimit(300000)
+	tx = signTx(txBuilder, privKeyRecipient, k.AccountKeeper().GetAccount(ctx, recipient))
+	txbz, err = testkeeper.EVMTestApp.GetTxConfig().TxEncoder()(tx)
+	require.Nil(t, err)
+	sum = sha256.Sum256(txbz)
+	res = testkeeper.EVMTestApp.DeliverTx(ctx.WithEventManager(sdk.NewEventManager()), abci.RequestDeliverTx{Tx: txbz}, tx, sum)
+	require.Equal(t, uint32(0), res.Code)
+	receipt, err = testkeeper.EVMTestApp.EvmKeeper.GetTransientReceipt(ctx, common.BytesToHash(sum[:]))
+	require.Nil(t, err)
+	require.Equal(t, 1, len(receipt.Logs))
+	require.NotEmpty(t, receipt.LogsBloom)
+	require.Equal(t, mockPointerAddr.Hex(), receipt.Logs[0].Address)
+	require.Equal(t, uint32(0), receipt.Logs[0].Index)
+	ownerHash = receipt.Logs[0].Topics[1]
+	// make sure that the owner is set correctly to the creator, not the spender.
+	creatorEvmAddr = testkeeper.EVMTestApp.EvmKeeper.GetEVMAddressOrDefault(ctx, creator)
+	require.Equal(t, common.BytesToHash(creatorEvmAddr[:]).Hex(), ownerHash)
+	tokenIdHash = receipt.Logs[0].Topics[3]
+	require.Equal(t, "0x0000000000000000000000000000000000000000000000000000000000000002", tokenIdHash)
+	require.Equal(t, common.HexToHash("0x0").Bytes(), receipt.Logs[0].Data)
+
 	// revoke all
 	payload = []byte(fmt.Sprintf("{\"revoke_all\":{\"operator\":\"%s\"}}", recipient.String()))
 	msg = &wasmtypes.MsgExecuteContract{