Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

side_channels: Add ML KEM report #237

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

side_channels: Add ML KEM report #237

wants to merge 6 commits into from

Conversation

aewag
Copy link
Collaborator

@aewag aewag commented Oct 11, 2024 •
edited
Loading

draft, not yet ready for review

@reneme reneme added this to the Botan 3.6.0 milestone Oct 22, 2024
@reneme reneme changed the base branch from release/3.5.0 to main October 29, 2024 14:22
@reneme
Copy link
Collaborator

reneme commented Oct 29, 2024 •
edited
Loading

@aewag I rebased this draft to the currrent main branch and re-targetted the pull request onto main as well. Please be aware when you continue working on this.

Also, I fixed a few minor things and used the :srcref: extension in explicit commits.

@reneme reneme mentioned this pull request Oct 29, 2024
Merged
@reneme reneme mentioned this pull request Oct 29, 2024
Draft
@falsecurity falsecurity marked this pull request as ready for review November 18, 2024 02:07
FAlbertDev
FAlbertDev approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@FAlbertDev FAlbertDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report, and sorry for the late response. I admit, I forgot about it 😅 Looks good to me, I've only got some tiny nits.

docs/audit_report/src/side_channels/01_03_ml_kem.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_03_ml_kem.rst Show resolved Hide resolved
docs/audit_report/src/side_channels/01_03_ml_kem.rst Outdated Show resolved Hide resolved
docs/audit_report/src/side_channels/01_03_ml_kem.rst Outdated Show resolved Hide resolved
@aewag
Copy link
Collaborator Author

aewag commented Dec 17, 2024

Thanks for the report, and sorry for the late response. I admit, I forgot about it 😅 Looks good to me, I've only got some tiny nits.

No worries, I was just looking at it to finally finish :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FAlbertDev FAlbertDev FAlbertDev approved these changes

Assignees
No one assigned
Labels
auditreport side channel report
Projects
None yet
Milestone
Botan 3.6.1
Development

Successfully merging this pull request may close these issues.
3 participants
@aewag @reneme @FAlbertDev