Support metadata request v6 #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @mtkopone, Thanks for this contribution! Something seems to have gone wrong with the CI run and I'm unable to re-run it. Would you be able to push and empty commit to see if that gets it running properly, thanks! |
mtkopone
force-pushed
the
support-metadata-request-v6
branch
from
1879b68 to
173c0f1
Compare
|
Tried pushing an empty commit (and also rebased to main), same problem. Apparently something is broken in circleci? |
…sponse. Maybe fixing TestDialer for old kafkas
|
After a couple of small fixes and a couple of reruns of circleci, all checks are now passing. |
rhansen2
reviewed
Oct 25, 2022
rhansen2
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for metadata requests with v6.
MSK Serverless fails with a EOF for all metadata requests with a version of less than 6.
This is one step towards fixing #967