Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Criteo] Audience Destination: set enable_batching to true by default #2771

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MarcDillar
Copy link
Contributor

Set the enable batching option to true by default as the performances of the Criteo Audience API are optimized for batched requests.

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@MarcDillar MarcDillar requested a review from a team as a code owner February 27, 2025 13:28
@brennan brennan added triaged Acknowledged by the Segment team, but not yet scheduled for review/deploy. eng-acknowledged This PR has been acknowledged by the engineering team. and removed triaged Acknowledged by the Segment team, but not yet scheduled for review/deploy. labels Mar 7, 2025
Copy link
Contributor

@marinhero marinhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MarcDillar, can you set enable_batching.required: false as this is a destination that's currently out there and setting a new required field will have unintended consequences? Thanks!

@MarcDillar
Copy link
Contributor Author

Hi @marinhero Thank you for the suggestion. I just set enable_batching.required to false.

@marinhero
Copy link
Contributor

marinhero commented Mar 18, 2025

@MarcDillar thanks! looks like that worked. Can you run $ ./bin/run generate:types for me? Add the result to a commit and that should get the CI / Validate (22.x) check to pass. We will proceed to plan your release afterwards.

@MarcDillar
Copy link
Contributor Author

Hi @marinhero, thanks for your help. I just updated the generated types for this destination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants