Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[algolia-insights] update presets for conversion events #2770

Conversation

jkaho
Copy link
Contributor

@jkaho jkaho commented Feb 27, 2025

Summary

Update the available presets / pre-built mappings to make configuring ecommerce conversions less confusing (current presets shown in screenshot).

Screenshot 2025-02-27 at 3 58 17 pm

  • Split Send conversion events to Algolia preset into Send purchase events to Algolia and Send add-to-cart events to Algolia. We already treat a generic Conversion Event as a purchase, so this makes it clearer.
  • Update Conversion Events action description.
  • Mark the Product Added action as deprecated and remove Send product added events to Algolia preset. This maps more closely to our Insights API spec where we consider add-to-carts and purchases "subtypes" of a conversion-type event. The generic conversion event also enables specifying revenue data for multiple objects, which the Product Added event does not.

Testing

This change mainly involved updating the presets. The only change to the actual Destination Actions were in the descriptions, lmk if there's some way I should be testing that.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@jkaho jkaho marked this pull request as ready for review February 28, 2025 04:15
@jkaho jkaho requested a review from a team as a code owner February 28, 2025 04:15
@brennan brennan added deploy:push triaged Acknowledged by the Segment team, but not yet scheduled for review/deploy. eng-acknowledged This PR has been acknowledged by the engineering team. and removed triaged Acknowledged by the Segment team, but not yet scheduled for review/deploy. labels Mar 7, 2025
Copy link
Contributor

@marinhero marinhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jkaho! After approving your PR the CI tests ran and one of them broke for your destination. Mindtaking a look and patching it? Thanks!

Screenshot 2025-03-11 at 12 42 10 PM

@jkaho jkaho requested a review from marinhero March 17, 2025 05:42
@jkaho
Copy link
Contributor Author

jkaho commented Mar 17, 2025

@marinhero thanks for the review 🙏 I've pushed a fix for the failing tests

@marinhero
Copy link
Contributor

Approved and scheduled for deploy on 03/25. Might go out sooner if we run an unscheduled release (we often do). Thank you!

@varadarajan-tw varadarajan-tw merged commit 8b3b1e2 into segmentio:main Mar 25, 2025
17 of 19 checks passed
@varadarajan-tw
Copy link
Contributor

@jkaho - This PR has been deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants