Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alec segment connector #2726

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alecbatch
Copy link

@alecbatch alecbatch commented Feb 5, 2025

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@marinhero
Copy link
Contributor

Hi @alecbatch. Is this ready for review? I see a bunch of code being commented out and I'm unsure if you intended to open a draft instead. LMK and I'll take a look. Thanks!

@alecbatch
Copy link
Author

Hi @marinhero I've just come back from holiday, thanks for your message. Yes, the code is ready for review, there's no need to take into account the bunch commented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants