This repository has been archived by the owner on Mar 17, 2024. It is now read-only.
Common usecase for a servicemonitor is to add additional labels to it… #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… via: targetlabels. These labels are pulled from the Service though so we need to be able to add labels to a service.
JohnPreston
pushed a commit
to compose-x/kafka-lag-exporter
that referenced
this pull request
Mar 4, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Common usecase for a servicemonitor is to add additional labels to the metrics via targetlabels (.spec.prometheus.servicemonitor.additionalConfig.targetLabels). These labels are pulled from the Service though so we need to be able to add labels to a service.
Would appreciate it @seglo if we can get a new helm chart with this in it. Thanks!