Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto brighntness toggle #3430

Closed
2 tasks done
AshishKalkandha opened this issue Dec 2, 2024 · 25 comments
Closed
2 tasks done

auto brighntness toggle #3430

AshishKalkandha opened this issue Dec 2, 2024 · 25 comments
Labels
unrelated Not related to the app

Comments

@AshishKalkandha
Copy link

Rules

  • I made myself familiar with the Readme, FAQ and Troubleshooting.
  • I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

Screens brighness keep changing on based on content on display. brightness increases on white content and dim on black or dark content. no auto brightness option found on display setting on windows settings [zephrus g16] (2024)

Describe the solution you'd like

An auto brightness toggle can be added to g-helper app

Describe alternatives you've considered

or any other way to changes the option. brightness changing like this is irritating and feels bad for eyes.

Device and Model

Asus Zephyrus G16 (2024)

Additional information.

GU605MI

@seerge
Copy link
Owner

seerge commented Dec 2, 2024

@AshishKalkandha hello,

It must be turned on in Windows somewhere still, check for the checkbox deeper, or it could be some weird setting inn GPU driver control panel. For example under Intel Command center (or how it’s called correctly), so check there.

G-Helper is not a driver and is not analysing screen contents to adjust brightness :)

Thanks

@seerge seerge added the unrelated Not related to the app label Dec 2, 2024
@seerge seerge closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
@AshishKalkandha
Copy link
Author

AshishKalkandha commented Dec 3, 2024

it's happening after I uninstalled armory crate and installed g-helper. before that screen brightness was working fine(normal).
installing armoury crate fixed the issue. that's why i think g-helper should also have that feature.
keeping both software isn't recommended, right?

Screenshot 2024-12-03 113254
what does this slider do? (please explain)

Screenshot 2024-12-03 115419
and what is this option in armoury crate?? [missing in g-helper]

@seerge
Copy link
Owner

seerge commented Dec 4, 2024

@AshishKalkandha hello,

Flicker free dimming is not Auto brightness, it’s what you have under OLED settings in AC too.

As for that “Optimal Display Brightness”, what exactly does it do in AC? Does turning it off - stops auto brightness changes? If so - did you use official AC uninstaller app when removing AC? (i want to understand if it’s either just AC leftover that was changing brightness for you or is it some new hardware-toggle)

@AshishKalkandha
Copy link
Author

AshishKalkandha commented Dec 6, 2024

@AshishKalkandha hello,

Flicker free dimming is not Auto brightness, it’s what you have under OLED settings in AC too.

As for that “Optimal Display Brightness”, what exactly does it do in AC? Does turning it off - stops auto brightness changes? If so - did you use official AC uninstaller app when removing AC? (i want to understand if it’s either just AC leftover that was changing brightness for you or is it some new hardware-toggle)

I don't have OLED Screen, it's IPS. I have Ultron 9, 32GB RAM and rtx 4070 with IPS display.
And I don't know about AC or what it's full form or meaning.
Is it a software or some feature/section in g-helper/armoury Crate.

I can share more information about my hardware or software if it can help to improve the software.

By the way: I reinstalled the Armoury Crate just to take a screenshot of that displays related option but just after installation that auto brightness stopped without changing any setting or option.

@RPochyly
Copy link

Hello @seerge
After troubleshooting for hours, I can confirm that disabling the adaptive contrast setting (referred to as "Optimal Display Brightness" in AC) is the only solution that works.

I tried looking in Windows settings for "Change brightness based on content" setting, as mentioned on the official ASUS support website, but the option is completely missing.

I also tried searching AMD Software and NVIDIA app for similar settings. AMD has recently removed the Varibright option from their software because of the toggle in Windows settings mentioned earlier. Even after modifying the registry keys for Varibright, the adaptive contrast from ASUS was still active.

The last thing I tried was using Linux to check if the adaptive contrast still works there. I tested various kernel parameters to disable varibright and even after uninstalling the mesa drivers, the adaptive contrast was still active, even in TTY in a minimal environment.

After all this troubleshooting, I'm fairly certain that the adaptive contrast ASUS uses isn't implemented in Windows, AMD drivers or NVIDIA drivers (Varibright setting does absolutely nothing even with the NVIDIA GPU disabled). I'm not too knowledgeable about how laptops work but I suspect that ASUS uses some kind of display controller chip for adaptive contrast. The chip appears to be controllable only via the AC setting - which could explain the missing Windows setting.

My model: ASUS A16 FA608WI
GPUs: AMD Radeon 890M and RTX 4070
CPU: Ryzen AI 9 HX 370

If you could add the Optimal Display Brightness setting to G-Helper, I would gladly donate 10€. As a computer science student, having the entire screen dim when I open an IDE with dark mode is a huge inconvenience and having this option in G-Helper would greatly improve my experience.

Merry Christmas, and thank you for your work on G-Helper!

@seerge
Copy link
Owner

seerge commented Dec 23, 2024

@RPochyly @AshishKalkandha hello,

Most likely it's one more and new proprietary toggle that Asus has added (introduced only for latest devices, released mid-2024).

To discover endpoint responsible for this toggle I need help from someone who actually has device with it. What needs to be done.

  1. Quit app and add following line to the beginning of %appdata%\GHelper\config.json, then save it and start app again.
"debug": 1,
  1. Run app again, open Extra settings and click on a new Zoom-glass icon there, it will do endpoint scan
  2. Change Optimal Display Brightness setting in AC to the opposite
  3. Run scan under Extra again
  4. Upload scan result here.

Also make a DSDT dump as explained in this topic (method2)

Thanks

@RPochyly
Copy link

Hi,
Here is the scan.txt. I think the first scan was with the Optimal Display Brightness disabled and the second scan was with it enabled.

I tried to make a DSDT dump. It successfully created many files after the first command (./acpidump.exe -b), but the second command ./iasl.exe dsdt.dat failed with this error
Error 6092 - Could not open file "dsdt.dat" (Source Input) - No such file or directory. The second command was run in the same directory as the first one. I searched the net and tried a command which worked and created the dsdt.dat file. Here is the command ./acpidump.exe -b -n DSDT and here is the file with .txt extension as GitHub doesn't support the dsl file extension: dsdt.dsl

If you need anything else, please let me know!

@seerge
Copy link
Owner

seerge commented Dec 23, 2024

@RPochyly ok, great!

Seems like 0005002A endpoint has changed from 1 to 0.

Can you now open Extra settings and into new DEVS section there enter 5002A in first field and 1 / 0 into second. This would manually send a command.

And check if it indeed enables and disables Auto Brightness ?

@RPochyly
Copy link

Yes, it works! Setting 5002A to 1 enables Optimal Display Brightness and setting it to 0 disables it. The smooth transition (of increasing/decreasing brightness while toggling ODB) which takes about 5 seconds is exactly the same as with AC.

seerge added a commit that referenced this issue Dec 23, 2024
@seerge
Copy link
Owner

seerge commented Dec 23, 2024

@RPochyly great! Good news.

Try this build, I have added an Optimal Display Brightness checkbox to Extra settings (where app keeps rarely used stuff)
GHelper.zip

And quick question. Do I understand correctly that device remembers this settings even after reboots or shutdowns ? I.e. there is no need to "set" it manually on each start?

@RPochyly
Copy link

The toggle works! I think the device remembers the setting.
I restarted and the Optimal Display Brightness wasn't turned on (it was also disabled before the restart). Then I shut down the laptop and waited 15 minutes to (hopefully) clear the volatile memory of the display controller as I have no idea where this setting is stored. After about 15 minutes of being shut down, the ODB was still disabled, which means that the setting should be persistent.

Thank you for your help! By the way, when do you approximately expect this feature to be added to stable releases?

@seerge
Copy link
Owner

seerge commented Dec 23, 2024

@RPochyly great, thanks for help and discovery.

It will be live in the next release. But since I just pushed 0.200, it will take some time as I usually try to accumulate a bunch of changes together unless this is something very important :)

@RPochyly
Copy link

Of course, I understand that. I'm glad that I could help. I've already sent you a donation for your kind help.

Anyway, have a wonderful Christmas!

@seerge
Copy link
Owner

seerge commented Dec 23, 2024

@RPochyly thanks, same to you.

@seerge seerge reopened this Dec 23, 2024
@seerge seerge closed this as completed Dec 23, 2024
@RPochyly
Copy link

RPochyly commented Dec 24, 2024

Hello @seerge
After further testing, it seems that the Optimal Display Brightness setting resets to "enabled" after about two hours of the laptop being shut down. So the setting is not persistent after all, it just takes quite a bit of time to reset to it's default value.

@seerge
Copy link
Owner

seerge commented Dec 24, 2024

@RPochyly do you still have AC or leftovers running ? (mainly Armoury Crate service)

@RPochyly
Copy link

No, I uninstalled it (official installer) after you had sent me the build of GHelper with the ODB toggle. I have no other features that I would use in AC, so I decided to uninstall it. I've just checked installed programs (using control panel) and there isn't anything AC related. I still have a few ASUS services (most of them stopped) for MyASUS I think. Do you think that these would cause the setting to revert to enabled? image

@seerge
Copy link
Owner

seerge commented Dec 24, 2024

@RPochyly my thought was that something else has enabled it back :) may be try to stop all other services and see if it resets back to ON? btw when it does - does checkbox under Extra reflect it ?

@RPochyly
Copy link

Yes, it seems to reset with all ASUS services stopped. I even tried Linux which I think has no ASUS services that could interfere and although I had no way to 100% sure, the dimming based on display content was turned on. I am certain that I disabled ODB before shutting down the laptop for several hours before booting to Linux.

Also yes, the checkbox under Extra reflects it correctly.

seerge added a commit that referenced this issue Dec 26, 2024
@seerge
Copy link
Owner

seerge commented Dec 26, 2024

@RPochyly ok, try this build. It should also set last used Optimal Brightness status on app start.

GHelper.zip

@RPochyly
Copy link

After having the laptop shut down overnight, the new build correctly sets the previous setting (ODB off in this case).
I think that everything concerning Optimal Display Brightness works great as of this build.

@injkgz
Copy link

injkgz commented Jan 27, 2025

Image
Hi! @seerge why I don't have this feature?
I'm g16 2024 intel core ultra 7 155 h owner

@Emile86
Copy link

Emile86 commented Jan 30, 2025

Image Hi! @seerge why I don't have this feature? I'm g16 2024 intel core ultra 7 155 h owner

Same here with G16 2024 core ultra 9 and Oled screen

@seerge
Copy link
Owner

seerge commented Jan 30, 2025

@injkgz @Emile86 hello, if you don't see that option - your device does not support it. Asus has added it only for Mid 2024+ models (i.e. G16 with AMD CPU and some new TUF models)

@Emile86
Copy link

Emile86 commented Jan 30, 2025

@injkgz @Emile86 hello, if you don't see that option - your device does not support it. Asus has added it only for Mid 2024+ models (i.e. G16 with AMD CPU and some new TUF models)

Thank you for the clarification 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unrelated Not related to the app
Projects
None yet
Development

No branches or pull requests

5 participants