-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auto brighntness toggle #3430
Comments
@AshishKalkandha hello, It must be turned on in Windows somewhere still, check for the checkbox deeper, or it could be some weird setting inn GPU driver control panel. For example under Intel Command center (or how it’s called correctly), so check there. G-Helper is not a driver and is not analysing screen contents to adjust brightness :) Thanks |
@AshishKalkandha hello, Flicker free dimming is not Auto brightness, it’s what you have under OLED settings in AC too. As for that “Optimal Display Brightness”, what exactly does it do in AC? Does turning it off - stops auto brightness changes? If so - did you use official AC uninstaller app when removing AC? (i want to understand if it’s either just AC leftover that was changing brightness for you or is it some new hardware-toggle) |
I don't have OLED Screen, it's IPS. I have Ultron 9, 32GB RAM and rtx 4070 with IPS display. I can share more information about my hardware or software if it can help to improve the software. By the way: I reinstalled the Armoury Crate just to take a screenshot of that displays related option but just after installation that auto brightness stopped without changing any setting or option. |
Hello @seerge I tried looking in Windows settings for "Change brightness based on content" setting, as mentioned on the official ASUS support website, but the option is completely missing. I also tried searching AMD Software and NVIDIA app for similar settings. AMD has recently removed the Varibright option from their software because of the toggle in Windows settings mentioned earlier. Even after modifying the registry keys for Varibright, the adaptive contrast from ASUS was still active. The last thing I tried was using Linux to check if the adaptive contrast still works there. I tested various kernel parameters to disable varibright and even after uninstalling the mesa drivers, the adaptive contrast was still active, even in TTY in a minimal environment. After all this troubleshooting, I'm fairly certain that the adaptive contrast ASUS uses isn't implemented in Windows, AMD drivers or NVIDIA drivers (Varibright setting does absolutely nothing even with the NVIDIA GPU disabled). I'm not too knowledgeable about how laptops work but I suspect that ASUS uses some kind of display controller chip for adaptive contrast. The chip appears to be controllable only via the AC setting - which could explain the missing Windows setting. My model: ASUS A16 FA608WI If you could add the Optimal Display Brightness setting to G-Helper, I would gladly donate 10€. As a computer science student, having the entire screen dim when I open an IDE with dark mode is a huge inconvenience and having this option in G-Helper would greatly improve my experience. Merry Christmas, and thank you for your work on G-Helper! |
@RPochyly @AshishKalkandha hello, Most likely it's one more and new proprietary toggle that Asus has added (introduced only for latest devices, released mid-2024). To discover endpoint responsible for this toggle I need help from someone who actually has device with it. What needs to be done.
Also make a DSDT dump as explained in this topic (method2) Thanks |
Hi, I tried to make a DSDT dump. It successfully created many files after the first command ( If you need anything else, please let me know! |
@RPochyly ok, great! Seems like Can you now open And check if it indeed enables and disables Auto Brightness ? |
Yes, it works! Setting |
@RPochyly great! Good news. Try this build, I have added an And quick question. Do I understand correctly that device remembers this settings even after reboots or shutdowns ? I.e. there is no need to "set" it manually on each start? |
The toggle works! I think the device remembers the setting. Thank you for your help! By the way, when do you approximately expect this feature to be added to stable releases? |
@RPochyly great, thanks for help and discovery. It will be live in the next release. But since I just pushed 0.200, it will take some time as I usually try to accumulate a bunch of changes together unless this is something very important :) |
Of course, I understand that. I'm glad that I could help. I've already sent you a donation for your kind help. Anyway, have a wonderful Christmas! |
@RPochyly thanks, same to you. |
Hello @seerge |
@RPochyly do you still have AC or leftovers running ? (mainly Armoury Crate service) |
@RPochyly my thought was that something else has enabled it back :) may be try to stop all other services and see if it resets back to ON? btw when it does - does checkbox under |
Yes, it seems to reset with all ASUS services stopped. I even tried Linux which I think has no ASUS services that could interfere and although I had no way to 100% sure, the dimming based on display content was turned on. I am certain that I disabled ODB before shutting down the laptop for several hours before booting to Linux. Also yes, the checkbox under |
@RPochyly ok, try this build. It should also set last used Optimal Brightness status on app start. |
After having the laptop shut down overnight, the new build correctly sets the previous setting (ODB off in this case). |
|
Same here with G16 2024 core ultra 9 and Oled screen |
Rules
Is your feature request related to a problem? Please describe
Screens brighness keep changing on based on content on display. brightness increases on white content and dim on black or dark content. no auto brightness option found on display setting on windows settings [zephrus g16] (2024)
Describe the solution you'd like
An auto brightness toggle can be added to g-helper app
Describe alternatives you've considered
or any other way to changes the option. brightness changing like this is irritating and feels bad for eyes.
Device and Model
Asus Zephyrus G16 (2024)
Additional information.
GU605MI
The text was updated successfully, but these errors were encountered: