Add support for ROG Zephyrus G16 2024 AMD

[ItsLucas]

Rules

• I made myself familiar with the Readme, FAQ and Troubleshooting.
• I understand that, if insufficient information will be provided, my issue will be closed without an answer.

Is your feature request related to a problem? Please describe

I'm currently using G-Helper, but since this laptop has just been released yesterday, some feature may not be complete.
Not working:
No slash lighting control
Advanced CPU tuning are limited (only temp settings are available)
No curve optimizer settings (It should be available since it's an AMD laptop whatsoever)

Describe the solution you'd like

Enable support for G16 AMD like the Intel variant. (or like Zephyrus G14, if more similar)

Describe alternatives you've considered

No response

Device and Model

ROG Zephyrus G16 GA605WV (as shown on G-Helper title bar)

Additional information.

No response

[seerge]

@ItsLucas hello,

Do you have AMD model already? If so - can you post a log from %appdata%\GHelper? I will check why Slash Lighting is not there.

As for AMD undervolting, most l probably it's not possible yet at all. As for this purpose G-Helper uses UXTU's library under the hood.

Try to check if UXTU is able to set curve optimizations and if they really work (cause it could be that they are visible in UI but do nothing for example there)

Thanks

[seerge]

@ItsLucas and try this build, I have noticed that model name for AMD device (GA605) is different from Intel (GU605), I have added it to the Slash Lighting models list

GHelper.zip

[ItsLucas]

Hi,
I've tried your build, and slash lighting is still missing.
Here's the log attached from your build.
log.txt

[ItsLucas]

It's ok for not having curve optimizer, since zen5 cores are already pretty efficient.
I'll gtg sleep soon, if more information is needed just leave me comments

[ItsLucas]

[seerge]

@ItsLucas ok, can you download https://www.nirsoft.net/utils/usbdeview-x64.zip

And then find ASUS device with Product ID 0x193B there and post it's full details ?

I'm mainly interested in Feature Report Length param

[ItsLucas]

Hi,
I didn't find any device with mentioned Product ID.
I will attach a complete list of all usb devices found below.
listusb.txt

[seerge]

@ItsLucas hello, your list doesn't contain anything from asus at all. Can you please check for Asus devices with a similar product IDs ? It will be keyboard with 19b6 and one device with oder product id for slash lighting (assuming you have slash in a first place) . Thanks

[ItsLucas]

This is everything I got from the output

I can confirm that the device do have a slash, since it's glowing all over the place
Seems there is one device with 0b05:19b6, called "USB Input Device"

Offtopic: linux also fails drastically on this machine, especially asus-linux project and related tools
Since this is all-new zen5 platform, maybe something have changed?

[seerge]

@ItsLucas well, it has to be a device to communicate with it. Do you run USB view with admin permissions ?
You could have some strange local edition, with messed up IDs, etc.

You can check my discussion here #2046 and try to figure out how AC communicates with Slash Lighting device

[ItsLucas]

1. Yes, I do run the program as admin.
2. Earlier GU605 (G16 Intel) is fine in my country, naybe they messed up only in GA605
   I'll try and capture some packages

Edit: Seems I'm the first person who reports GA605 issue
It's also possible that the design is changed globally, not for a specific country

[seerge]

@ItsLucas try to search by feature report length, should be 128 for Slash Lighting.

But USB list still looks quite strange, as you have only one Asus Device (0b05) at all

[ItsLucas]

@seerge I tried device monitoring studio, and they seems to integrate everything into the only one Asus Device (0b05)
When I press keyboard, it logs;
When I change slash lighting mode, it logs crazily...

[ItsLucas]

slash lighting log.txt
slash_raw.txt
I got something for you, maybe it'll help

[ItsLucas]

Desktop.zip

[seerge]

@ItsLucas check if this build sees Slash
GHelper.zip

[ItsLucas]

This build sees Slash, but changing it won't affect the slash module.
I.E, change slash style, or turn it off, has no effect on the light itself
But changing in armoury crate works
I think the protocol may have changed too?

[seerge]

@ItsLucas could be, i'm not able to check DMS Log yet, but if protocol has change it means that we need to go through all steps from #2046 all over again

[seerge]

@ItsLucas can you quickly look at packets in monitoring studio, and check if you see Init command somewhere similar to this one

5E D7 00 00 01 AC  

It could be that only the first byte (i.e.5E has changed to something else)

[ItsLucas]

5D D2 02 01 08 AC ]?..?.
5D D3 03 01 08 AC FF FF 01 05 FF FF 00 00 00 00 ]?..?........
5D D4 00 00 01 AC 00 00 00 00 00 00 00 ]?...?.......
5D D2 02 01 08 AB 00 00 00 00 00 00 00 00 ]?..?.........
5D D2 01 13 40 00 ]?.@.

[seerge]

@ItsLucas try this build
GHelper.zip

[ItsLucas]

This build works perfectly.
Tested mode, on/off, brightness, interval, all function seems to be ok
Seems I can uninstall my AC again

[seerge]

Ok, amazing

[ItsLucas]

With some quick explore of related code in G-Helper
That seems just a public SlashPacket(byte[] command) : base(0x5D, 128, command)
dunno why asus's bother to change this

[ItsLucas]

Fun fact: G-Helper is the ONLY way to switch to Integrated graphics on GA605
The AC is buggy, and the button won't work

[seerge]

@ItsLucas yes, that is exactly what I have changed in the last build.

I will prepare a split in the code to support slash on other devices and yours and include in the next release then.

Thanks for testing

[seerge]

@ItsLucas btw, can you test if Custom power limits work on your device without applying a Custom fan curve next to them (under Fans + Power).

But please use mainstream build (i.e. latest 0.181 or 0.179)?

Cause on some models to make power limits work you also need to set fans (same as AC does in manual mode) and on some - you don't

In the build linked here app already silently sets fan curve if power limits are checked , cause G16 2024 with Intel required that ...

[ItsLucas]

I used the latest stable release, found that I can slide the slider freely.
How to check if the charge limits are actually working?
I only see "smart charging" appears on my battery when I set the limit to exactly 80%.

[seerge]

@ItsLucas discharge laptop below 90, set 90 an monitor if it stops charging there or not

[ItsLucas]

Hi,
It seems that the charge limiter works between 55%-80%.
Setting anything below or above will trigger charging.

[alnandr]

@seerge Let me know if I can contribute to supporting these new laptops. I have the GA405WI model (upgraded configuration with RTX 4070) from ASUS for review, but I have not switched AC for G-Helper, anticipating that support for these new models may not be available yet. Would a log file suffice for your needs?

[seerge]

@ItsLucas hello, sorry for delay. Can you check if this build still shows and allows control for Slash Lighting ? (I have added a switch to support "both" versions of it for other devices and GA605)

GHelper.zip

@alnandr you can try that build as well. If you will read discussion in this thread Slash Lighting was pretty much the only missing part (as it's ID has changed specifically in this model comparing to others)

[seerge]

Live in https://github.com/seerge/g-helper/releases/tag/v0.182

[alnandr]

Live in https://github.com/seerge/g-helper/releases/tag/v0.182

This build does not see Slash Lighting on my GA405WI. Attached my log file.
log.txt

[seerge]

@alnandr can you post a list of devices from asus (vendor id 0b05) using https://www.nirsoft.net/utils/usbdeview-x64.zip here ?

[seerge]

@alnandr and can you check if this build makes a difference ?
GHelper.zip

[Dulshad]

With the build from your last reply, I can see the slash lighting(Previous didn't), however the config does nothing to the lighting. I use G16 GA605WV-QP060W. Same like the other user I only have one device from vendor id 0b05.

[alnandr]

@alnandr and can you check if this build makes a difference ? GHelper.zip

Same findings as Dulshad, Slash Lighting is now visible but nothing changes when modifying the configuration.

[ItsLucas]

@alnandr and can you check if this build makes a difference ? GHelper.zip

tried this build, the slash lighting control also breaks.

[alnandr]

@ItsLucas @alnandr @Dulshad

Ok, one more attempt - can you try if this build works ?

GHelper.zip

Slash Lightning disappeared from the configuration screen.

[seerge]

@alnandr that’s strange, can you post a log from this build?

[seerge]

@alnandr @Dulshad @ItsLucas one more attempt, try this build instead

GHelper.zip

[Dulshad]

@seerge Hello, it works now! Thank you for your work!

[seerge]

@ItsLucas ok, finally :)

[alnandr]

Update: All confirmed working on GA405WI!

Glad to hear, I will test on my model when I get home tonight and report back that both configs are covered :) great work as usual @seerge

[seerge]

Ok, great. Pushed last tweaks into https://github.com/seerge/g-helper/releases/tag/v0.183

[HL2512]

Hello @seerge , can you please tell me how long the g16 with amd CPU last with the new build you have with the G-Helper? Thank you so much for your possitive feedback.

[seerge]

@HL2512 hello, what exactly do you mean under "last" ?

[HL2512]

Oh sorry, my English was bad. What I mean was about the battery life, like how long I can use it with something like VSCode, Discord and Brave ( a web browser). Do you have any ideas about it?

[seerge]

@HL2512 ah, I guess it really depends on actual tasks running and power consumption :) I guess if you manage everything in a 8-10W discharge rate you should fit into 7-10 hours )

[HL2512]

Oh, thank you so much for your feedback, but just one more question, is the G-helper work with the duo 16 ( the zephyrus station lol :))) ) and make it better?

[seerge]

@HL2512 yes - it does work with DUO 16 (pretty much as with any modern asus laptop / handheld)

[HL2512]

Thank you so much for your answer man, have a great day. or night in your place :>