-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamlining PR pipeline #1378
Merged
payalcha
merged 15 commits into
securefederatedai:develop
from
payalcha:changes-in-pipeline
Feb 14, 2025
Merged
Streamlining PR pipeline #1378
payalcha
merged 15 commits into
securefederatedai:develop
from
payalcha:changes-in-pipeline
Feb 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
Signed-off-by: Chaurasiya, Payal <[email protected]>
noopurintel
reviewed
Feb 14, 2025
Signed-off-by: Chaurasiya, Payal <[email protected]>
noopurintel
approved these changes
Feb 14, 2025
teoparvanov
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you @payalcha and @noopurintel ! Hopefully those improvements will help us catch potential regressions early, during the PR pipeline.
rajithkrishnegowda
approved these changes
Feb 14, 2025
tanwarsh
approved these changes
Feb 14, 2025
MasterSkepticista
approved these changes
Feb 14, 2025
Signed-off-by: Chaurasiya, Payal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple duplicate jobs present in the pipeline.
Removing the duplicate jobs from pipeline and adding E2E tests instead.
https://wiki.ith.intel.com/display/TPE/Existing+Tests+in+OpenFL - Can discuss.
Changes done -
IMP - Resiliency testing is added in the PR pipeline it performs 30 rounds with torch/mnist and also performs multiple restarts while checking tensor.db for rounds. This test takes around ~12-15 mins. So PR pipeline will take little extra time overall.