-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hash algorithm transition plan #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks solid. Only one minor comment/suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 tiny typofix -- otherwise looks good to me.
pep-0458.txt
Outdated
However, once support for an old algorithm is turned off, clients that don't | ||
support the new algorithm will only be able to install or update packages, | ||
including the client itself, by disabling TUF verification. To allow clients to | ||
transition without temporarily loosing TUF security guarantees, we recommend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "losing", not "loosing"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted. Thanks! Fixed and force-pushed.
d9bfddd
to
8872dfd
Compare
Now that python#1203 is merged, we can't piggyback into upstream on the @trishankatdatadog, did you still want to leave a comment about referencing the newly added section somewhere else in the pep? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @lukpueh. Please address these few concerns, and let's open a new PR on upstream, please.
pep-0458.txt
Outdated
|
||
1. Implement new algorithm in Warehouse. | ||
|
||
2. Re-generate existing TUF metadata to include both old and new algorithm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rewrite this sentence to say something like: "Regenerate existing, unexpired to include hashes using both the old and new algorithms. All new metadata going forward shall list both hash algorithms."
pep-0458.txt
Outdated
metadata needs to be renewed, that is *bin-n*, *snapshot* and *timestamp*. | ||
Thus, only online keys are required to sign renewed metadata. | ||
|
||
3. Announce transition on high-visibility channels. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Such as? The Python Discourse?
Add subsection to section "Managing Future Changes to the Update Process" that explains how to transition from an old (weak) to a new (stronger) hashing algorithm without disrupting client workflows.
8872dfd
to
47e0ced
Compare
Thanks for the suggestions, @trishankatdatadog, I amended my last commit to integrate them and will open a new PR to upstream. |
Superseded by python#1253. Closing here. |
Picks up discussion from #68
Add subsection to section "Managing Future Changes to the Update Process" that explains how to transition from an old (weak) to a new (stronger) hashing algorithm without disrupting client workflows.