Replace tuf roles overview image with text table #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukpueh
commented
Nov 21, 2019
| | | resulting delegated roles can then provide their own | | ||
| | | metadata files. The format of the metadata files provided | | ||
| | | by delegated targets roles is the same as that of | | ||
| | | targets.json. As with targets.json, the latest version of | |
There was a problem hiding this comment.
Might be good to state that the targets role writes to "targets.json", at this point the reader does not know that yet (they might have a suspicion though).
There was a problem hiding this comment.
Go for it :yolo:
pep-0458.txt
Outdated
| | | versions of all metadata files on the repository in | | ||
| | | snapshot.json. The only metadata file not listed in | | ||
| | | snapshot.json is timestamp.json, which is always created | | ||
| | | after snapshot.json. | |
There was a problem hiding this comment.
This needs to be updated to the latest version of the spec. The current spec does not have root in snapshot either.
|
@lukpueh Go for it, do what you think is best |
|
@trishankatdatadog, let me know what you think of 5b8e5b1. The targets update is not absolutely necessary. But we do need to mention that root is no longer in snapshot. Feel free to suggest alternative wording. |
| | | resulting delegated roles can then provide their own | | ||
| | | metadata files. The format of the metadata files provided | | ||
| | | by delegated targets roles is the same as that of | | ||
| | | targets.json. As with targets.json, the latest version of | |
There was a problem hiding this comment.
Go for it :yolo:
Requires updating other captions: - Figure 2 --> Figure 1 - Table 1, 2, 4 --> Table 2, 3, 4 This commit also removes a stray "and".
- Update targets row to say that it signs the targets metadata - Update snapshot row to mention that it only lists targets and targets metadata and why it doesn't list root and timestamp. Co-Authored-By: Trishank Karthik Kuppusamy <[email protected]>
lukpueh
force-pushed
the
table-to-texttable
branch
from
0aef6f3 to
1374e1c
Compare
lukpueh
added a commit
to lukpueh/peps
that referenced
this pull request
Mar 5, 2020
In secure-systems-lab#73 Figure 2 became Figure 1. This change fixes a missed reference update. It also removes a stray "and". Signed-off-by: Lukas Puehringer <[email protected]>
ewdurbin
added a commit
to python/peps
that referenced
this pull request
Mar 5, 2020
In secure-systems-lab#73 Figure 2 became Figure 1. This change fixes a missed reference update. It also removes a stray "and". Signed-off-by: Lukas Puehringer <[email protected]>
mnm678
pushed a commit
to mnm678/peps
that referenced
this pull request
Oct 22, 2020
In secure-systems-lab#73 Figure 2 became Figure 1. This change fixes a missed reference update. It also removes a stray "and". Signed-off-by: Lukas Puehringer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66