-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify bins and bin-n in the table #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the analysis for the case where timestamp, snapshot, and bin-n has been compromised is inaccurate
Freeze and metadata inconsistency attacks are limited by earliest root, targets, and bins (but NOT bin-n) metadata expiration time
@@ -842,9 +843,9 @@ attack, or metadata inconsistency attacks. | |||
+-----------------+-------------------+----------------+--------------------------------+ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "targets OR bins OR bin-n" or "targets OR any delegated targets".
Alternatively, if we expect the reader to understand the delegation hierarchy, i.e. that compromising targets allows to compromise bins allows to compromise bin-n, then it might be enough to only mention bin-n, which is what the attacker is after. It seems to me that that's the assumption in the row below.
If we go with one of my suggestions from the top, I'd also change the row below to mention targets, bins and bin-n, and not just bin-n, for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference between "NO" and "NOT APPLICABLE" in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go with one of my suggestions from the top, I'd also change the row below to mention targets, bins and bin-n, and not just bin-n, for consistency.
I take that back. Only mentioning "bin-n" makes a difference in regards to Freeze Attack and Metadata Inconsistency Attack. As @trishankatdatadog says above targets and bins expiration times can stop them. And shouldn't they also stop Malicious updates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update to targets or bins or bin-n.
The NO vs NOT APPLICABLE was in the original text. I think they mean the same thing so will change them all to NO for consistency.
I agree with @trishankatdatadog, if bin-n is compromised the attacker has control over their expiration time. Well spotted! |
| snapshot | earliest root, | earliest root, | targets, or bins metadata | | ||
| **AND** | targets, or | targets, or | expiry time | | ||
| bin-n | bins expiry | bins expiry | | | ||
| | time | time | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also have a place for bins / targets + snapshot + timestamp compromise? Isn't this missing?
Fixes #26
Clarifies what happens if bins or bin-n keys are compromised. Please double check for correctness.