Minor tweaks #17
Merged
Minor tweaks #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even by the definitions section a reader will be confused without a passing familiarity with the spec, change the wording to be more explicit to those who aren't intimately familiar with RFC 2119
|
@joshuagl Thanks! Yes, please file an issue per major comment |
trishankatdatadog
requested changes
Oct 11, 2019
Co-Authored-By: Trishank K Kuppusamy <[email protected]>
trishankatdatadog
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some very minor tweaks whilst reading through the current PEP 458 for clarity as a non-expert reader.
I also have some bigger comments/queries - is the best place for those in an Issue on this repo?