Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: replace utcnow and utcfromtimestamp #4462

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Jul 14, 2024

They were deprecated in python/cpython#103857.

Closes #4460

Copy link

codecov bot commented Jul 14, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.49%. Comparing base (ed7225d) to head (c47b6cf).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4462      +/-   ##
==========================================
- Coverage   81.49%   81.49%   -0.01%     
==========================================
  Files         355      355              
  Lines       84643    84643              
==========================================
- Hits        68983    68980       -3     
- Misses      15660    15663       +3     
Files Coverage Δ
scapy/layers/http.py 83.53% <100.00%> (ø)
scapy/__init__.py 83.78% <50.00%> (ø)
scapy/modules/ticketer.py 35.66% <0.00%> (ø)
scapy/layers/kerberos.py 67.43% <33.33%> (ø)

... and 3 files with indirect coverage changes

@gpotter2 gpotter2 added this to the 2.6.0 milestone Jul 14, 2024
Copy link
Member

@gpotter2 gpotter2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks a lot for looking into it.

@gpotter2 gpotter2 merged commit 4a852fe into secdev:master Jul 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The tests seem to fail with -Werror (because utcnow and utcfromtimestamp are deprecated)
2 participants