Merge pull request orta#19 from johansteffner/master

Fix check for @types dependency
sebinsua · Apr 8, 2019 · b6fbfec · b6fbfec
2 parents 9c0d0e3 + 31ac522
commit b6fbfec
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/index.ts b/src/index.ts
@@ -206,7 +206,7 @@ export const checkForTypesInDeps = packageDiff => {
   const sentence = danger.utils.sentence
 
   if (packageDiff.dependencies && packageDiff.dependencies.added) {
-    const typesDeps = packageDiff.dependencies.added.filter(d => d.startsWith("@types")).map(printDep)
+    const typesDeps = packageDiff.dependencies.added.filter(d => d.startsWith("@types/")).map(printDep)
     if (typesDeps.length) {
       const message = `@types dependencies were added to package.json, as a dependency for others.`
       const idea = `You need to move ${sentence(typesDeps)} into "devDependencies"?`