Don't remove nested subdirectories #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate bot
referenced
this pull request
in jippi/dottie
Aug 4, 2024
…mod (#68) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/sebdah/goldie/v2](https://github.com/sebdah/goldie) | `v2.5.3` -> `v2.5.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>sebdah/goldie (github.com/sebdah/goldie/v2)</summary> ### [`v2.5.5`](https://github.com/sebdah/goldie/releases/tag/v2.5.5) [Compare Source](https://github.com/sebdah/goldie/compare/v2.5.4...v2.5.5) #### What's Changed - Accept sub sub test name for dir by [@​nervo](https://github.com/nervo) in [https://github.com/sebdah/goldie/pull/40](https://github.com/sebdah/goldie/pull/40) #### New Contributors - [@​nervo](https://github.com/nervo) made their first contribution in [https://github.com/sebdah/goldie/pull/40](https://github.com/sebdah/goldie/pull/40) **Full Changelog**: sebdah/goldie@v2.5.4...v2.5.5 ### [`v2.5.4`](https://github.com/sebdah/goldie/releases/tag/v2.5.4) [Compare Source](https://github.com/sebdah/goldie/compare/v2.5.3...v2.5.4) #### What's Changed - Add customizable equality compare option by [@​takashabe](https://github.com/takashabe) in [https://github.com/sebdah/goldie/pull/41](https://github.com/sebdah/goldie/pull/41) - Don't remove nested subdirectories by [@​adamhicks](https://github.com/adamhicks) in [https://github.com/sebdah/goldie/pull/43](https://github.com/sebdah/goldie/pull/43) #### New Contributors - [@​takashabe](https://github.com/takashabe) made their first contribution in [https://github.com/sebdah/goldie/pull/41](https://github.com/sebdah/goldie/pull/41) - [@​adamhicks](https://github.com/adamhicks) made their first contribution in [https://github.com/sebdah/goldie/pull/43](https://github.com/sebdah/goldie/pull/43) **Full Changelog**: sebdah/goldie@v2.5.3...v2.5.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative implementation to #42 that maybe solves issues with removing old test output.
The problem can be described with this example:
If we write an output file to
fixture/a/b/c/foo.bar, currently we will set the directory modification time ofcto the value of the variablets, this also changes the modification time for every parent ofc. Which means that if we also run a test inbwe will see a later modification time for the folderband hence clean that directory, removingcand any output inb.An alternative solution to this problem (other than the one given in this PR) could be to set the directory modification time for every directory between fixtureDir and the test dir. i.e. in the example above, when writing output to
c, set the modification timestamp forbandaas well.