Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Enable php_unit_set_up_tear_down_visibility fixer #4555

Conversation

localheinz
Copy link
Collaborator

@localheinz localheinz commented Dec 19, 2020

This PR

  • enables the php_unit_set_up_tear_down_visibility fixer
  • runs tools/php-cs-fixer fix

💁‍♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.17/doc/rules/php_unit/php_unit_set_up_tear_down_visibility.rst.

@localheinz localheinz added the type/build-automation Issues related to PHPUnit's build automation (GitHub Actions, etc.) label Dec 19, 2020
@localheinz localheinz marked this pull request as ready for review December 19, 2020 08:33
@codecov
Copy link

codecov bot commented Dec 19, 2020

Codecov Report

Merging #4555 (466db6e) into master (f2b649a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4555   +/-   ##
=========================================
  Coverage     84.32%   84.32%           
  Complexity     4543     4543           
=========================================
  Files           275      275           
  Lines         11780    11780           
=========================================
  Hits           9933     9933           
  Misses         1847     1847           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2b649a...466db6e. Read the comment docs.

@sebastianbergmann sebastianbergmann merged commit eb43017 into sebastianbergmann:master Dec 19, 2020
@localheinz localheinz deleted the feature/php-unit-set-up-tear-down-visibility branch December 19, 2020 09:30
@localheinz
Copy link
Collaborator Author

Thank you, @sebastianbergmann!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/build-automation Issues related to PHPUnit's build automation (GitHub Actions, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants