Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ruff and fix errors and warnings #468

Merged
merged 1 commit into from
Jul 28, 2024
Merged

update ruff and fix errors and warnings #468

merged 1 commit into from
Jul 28, 2024

Conversation

seapagan
Copy link
Owner

newest ruff seems more picky for noqa placement, fixed.

@seapagan seapagan added the dependencies Pull requests that update a dependency file label Jul 28, 2024
@seapagan seapagan self-assigned this Jul 28, 2024
Copy link

codacy-production bot commented Jul 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.11% (target: -1.00%) 33.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3b26583) 620 205 33.06%
Head commit (e513392) 619 (-1) 204 (-1) 32.96% (-0.11%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#468) 6 2 33.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@seapagan seapagan marked this pull request as ready for review July 28, 2024 12:39
@seapagan seapagan merged commit 5c2816f into main Jul 28, 2024
13 checks passed
@seapagan seapagan deleted the fix-ruff-issues branch July 28, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant