Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: set up github action workflow for rust #114

Merged
merged 8 commits into from
Dec 14, 2021
Merged

ci: set up github action workflow for rust #114

merged 8 commits into from
Dec 14, 2021

Conversation

PureWhiteWu
Copy link
Contributor

No description provided.

@PureWhiteWu PureWhiteWu mentioned this pull request Oct 22, 2021
Merged
@PureWhiteWu
Copy link
Contributor Author

image

You may need to do a one-time setup for actions and remove the travis.

@seanmonstar
Copy link
Owner

Thanks for starting this! It'd be helpful if we could carry over all the different OS/targets that are checked in Travis, since this crate is full of OS-specific code.

@PureWhiteWu
Copy link
Contributor Author

Thanks for starting this! It'd be helpful if we could carry over all the different OS/targets that are checked in Travis, since this crate is full of OS-specific code.

Hello, Windows and macOS support is added.

@PureWhiteWu
Copy link
Contributor Author

Hi, is there anything else need to do?

@seanmonstar
Copy link
Owner

Ideally, we could continue to test on the different targets that are seen in the .travis.yml file, and keep the container/cgroups tests as well.

@PureWhiteWu PureWhiteWu force-pushed the ci/github_actions branch 9 times, most recently from 04f6118 to eaba5cc Compare October 27, 2021 08:28
@PureWhiteWu
Copy link
Contributor Author

Hello, could you please merge this and #113 , and publish a new version? We are having problems in our production environment. @seanmonstar

@PureWhiteWu
Copy link
Contributor Author

PureWhiteWu commented Nov 4, 2021 •
edited
Loading

Hello, I've added all the target build tests in .travis.yml and some additional targets which Rust has Tier1 or Tier2 support. @seanmonstar
The tests are now all successful, you may take a look at PureWhiteWu#1

@PureWhiteWu
Copy link
Contributor Author

ping~ @seanmonstar

seanmonstar
seanmonstar reviewed Dec 13, 2021
View reviewed changes
Copy link
Owner

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including all the extra targets! I managed to overlook it last time, since they were all on a single line. This looks amazing!

.github/workflows/cargo-cross-build.yml Outdated Show resolved Hide resolved
@seanmonstar seanmonstar merged commit ef39d09 into seanmonstar:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmonstar seanmonstar seanmonstar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PureWhiteWu @seanmonstar