support heterogeneous cluster deployment #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ImageBuilding
kakaZhou719
changed the title
kakaZhou719
force-pushed
the
make-image-spec-more-consistent
branch
from
0437e21 to
585bf1f
Compare
kakaZhou719
changed the title
starnop
reviewed
Feb 17, 2023
cmd/sealer/cmd/image/pull.go
Outdated
| return fmt.Errorf("failed to pull image: %s", pullOpts.Image) | ||
| } | ||
|
|
||
| logrus.Infof("%s", imageID) |
There was a problem hiding this comment.
optimize the log output or delete it
starnop
reviewed
Feb 17, 2023
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package buildah |
There was a problem hiding this comment.
What are the considerations behind this file modification？
There was a problem hiding this comment.
this file contains image extension-related information used by sealer inspect, so i move those functions to inspect.go
added 2 commits
February 21, 2023 13:00
support heterogeneous clusters fix lint
kakaZhou719
force-pushed
the
make-image-spec-more-consistent
branch
from
585bf1f to
6a18354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
pull,inspect.Does this pull request fix one issue?
Fixes #2040
Describe how you did it
Describe how to verify it
Special notes for reviews