modify lvscare name #1937
Merged
modify lvscare name #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 17.51% // Head: 17.99% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1937 +/- ##
==========================================
+ Coverage 17.51% 17.99% +0.47%
==========================================
Files 103 104 +1
Lines 9139 9360 +221
==========================================
+ Hits 1601 1684 +83
- Misses 7325 7454 +129
- Partials 213 222 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
how about make it as a const value , replace it including registry lvscare and k8s runtime lvscare |
kakaZhou719
reviewed
Jan 16, 2023
common/common.go
Outdated
| @@ -40,6 +40,7 @@ const ( | |||
| KubeLvsCareStaticPodName = "kube-lvscare" | |||
| RegLvsCareStaticPodName = "reg-lvscare" | |||
| StaticPodDir = "/etc/kubernetes/manifests" | |||
| LvsCare = "sealerio/lvscare:v1.1.3-beta.8" | |||
pkg/registry/local.go
Outdated
| @@ -162,7 +162,7 @@ func (c *localConfigurator) configureLvs(registryHosts, clientHosts []net.IP) er | |||
| } | |||
|
|
|||
| //todo should make lvs image name as const value in sealer repo. | |||
| lvsImageURL := fmt.Sprintf("%s/sealer/lvscare:v1.1.3-beta.8", net.JoinHostPort(c.Domain, strconv.Itoa(c.Port))) | |||
| lvsImageURL := filepath.Join(net.JoinHostPort(c.Domain, strconv.Itoa(c.Port)), common.LvsCare) | |||
There was a problem hiding this comment.
in cluster runtime, we also need to replace this value.
Stevent-fei
force-pushed
the
modify_lvscare_name
branch
from
af383a5 to
a426658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
Describe how to verify it
Special notes for reviews